Skip to content

[feat] Support *:<partition name> name pattern in the list of valid systems #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 14, 2020
Merged

[feat] Support *:<partition name> name pattern in the list of valid systems #1253

merged 14 commits into from
Apr 14, 2020

Conversation

@mboisson
Copy link
Contributor

@mboisson mboisson commented Apr 3, 2020 •
edited by vkarak
Loading

Fixes #1126.

@pep8speaks
Copy link

pep8speaks commented Apr 3, 2020 •
edited
Loading

Hello @mboisson, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2020-04-14 12:40:19 UTC

@jenkins-cscs
Copy link
Collaborator

jenkins-cscs commented Apr 3, 2020

Can I test this patch?

@codecov-io
Copy link

codecov-io commented Apr 3, 2020 •
edited
Loading

Codecov Report

Merging #1253 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1253   +/-   ##
=======================================
  Coverage   91.39%   91.40%           
=======================================
  Files          84       84           
  Lines       12409    12421   +12     
=======================================
+ Hits        11341    11353   +12     
  Misses       1068     1068
Impacted Files Coverage Δ
reframe/core/pipeline.py 92.32% <100.00%> (-0.03%) ⬇️
unittests/test_pipeline.py 95.40% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e167d8d...99f2843. Read the comment docs.

@vkarak vkarak requested review from victorusu and vkarak April 3, 2020 18:05
@vkarak vkarak added this to the ReFrame sprint 20.06 milestone Apr 3, 2020
@vkarak
Copy link
Contributor

vkarak commented Apr 3, 2020

test this please

@vkarak vkarak changed the title adding the option to specify *:<partition name> as a list of system [feat] Support *:<partition name> pattern as a list of valid systems Apr 3, 2020
@vkarak vkarak requested a review from teojgo April 3, 2020 18:10
@mboisson
Copy link
Contributor Author

mboisson commented Apr 3, 2020

test this please

@vkarak, are you talking to the bot ? or to me ? or someone else ?

@vkarak
Copy link
Contributor

vkarak commented Apr 3, 2020

Hey @mboisson, thanks for the PR! I was talking to the bot. It's a bit silly. It doesn't understand when you address it directly; only if you shout it out in general. But that's only for the first time contributors. :-)

@mboisson
Copy link
Contributor Author

mboisson commented Apr 3, 2020

haha, ok. No problem :)

teojgo
teojgo requested changes Apr 6, 2020
View reviewed changes
vkarak
vkarak requested changes Apr 7, 2020
View reviewed changes
@mboisson
Copy link
Contributor Author

mboisson commented Apr 7, 2020

Looks like I need to think about this a bit more... 🤔

@vkarak
Copy link
Contributor

vkarak commented Apr 7, 2020

Actually you can try to run the unit tests yourself by running ./test_reframe.py. It accepts all the pytest options.

@mboisson
Copy link
Contributor Author

mboisson commented Apr 7, 2020

Ok, should be good now.

@mboisson mboisson requested a review from vkarak April 7, 2020 15:19
vkarak
vkarak requested changes Apr 8, 2020
View reviewed changes
@vkarak
Copy link
Contributor

vkarak commented Apr 14, 2020

@mboisson my plan is to merge this today, so I will go on with the solution of changing the type of the valid_systems field.

vkarak
vkarak approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak
Copy link
Contributor

vkarak commented Apr 14, 2020

@teojgo Can you approve this one?

@vkarak vkarak changed the title [feat] Support *:<partition name> pattern as a list of valid systems [feat] Support *:<partition name> as a valid pattern in the list of valid systems Apr 14, 2020
@vkarak vkarak changed the title [feat] Support *:<partition name> as a valid pattern in the list of valid systems [feat] Support *:<partition name> pattern in the list of valid systems Apr 14, 2020
@vkarak vkarak changed the title [feat] Support *:<partition name> pattern in the list of valid systems [feat] Support *:<partition name> name pattern in the list of valid systems Apr 14, 2020
@vkarak vkarak merged commit 60015c3 into reframe-hpc:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@teojgo teojgo teojgo approved these changes

@victorusu victorusu Awaiting requested review from victorusu

Assignees

@mboisson mboisson

Labels

enhancement prio: normal

Projects

None yet

Milestone

ReFrame sprint 20.05

Development

Successfully merging this pull request may close these issues.

Supporting valid_systems = ['*:partition_name']

6 participants

@mboisson @pep8speaks @jenkins-cscs @codecov-io @vkarak @teojgo