Skip to content

[bugfix] Fix deprecation warnings in unit tests #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2020
Merged

[bugfix] Fix deprecation warnings in unit tests #1287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e642854
Fix unittest deprecation warnings
ekouts May 5, 2020
2eee7ef
Treat ReframeDeprecationWarning as error in jenkins
ekouts May 5, 2020
bbe2f76
Mark SelfKillCheck as a special test
ekouts May 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ci-scripts/ci-runner.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,8 @@ if [ $CI_GENERIC -eq 1 ]; then
echo "========================================"
echo "Running unit tests with generic settings"
echo "========================================"
checked_exec ./test_reframe.py
checked_exec ! ./bin/reframe.py --system=generic -l 2>&1 | \
checked_exec ./test_reframe.py -W=error::reframe.core.exceptions.ReframeDeprecationWarning
checked_exec ! ./bin/reframe.py -W=error::reframe.core.exceptions.ReframeDeprecationWarning --system=generic -l 2>&1 | \
grep -- '--- Logging error ---'
elif [ $CI_TUTORIAL -eq 1 ]; then
# Run tutorial checks
Expand All @@ -190,7 +190,7 @@ else
echo "Running unit tests"
echo "=================="

checked_exec ./test_reframe.py --rfm-user-config=config/cscs-ci.py
checked_exec ./test_reframe.py -W=error::reframe.core.exceptions.ReframeDeprecationWarning --rfm-user-config=config/cscs-ci.py

if [[ $(hostname) =~ dom ]]; then
PATH_save=$PATH
Expand All @@ -199,7 +199,7 @@ else
echo "Running unit tests with ${backend}"
echo "=================================="
export PATH=/apps/dom/UES/karakasv/slurm-wrappers/bin:$PATH
checked_exec ./test_reframe.py --rfm-user-config=config/cscs-${backend}.py
checked_exec ./test_reframe.py -W=error::reframe.core.exceptions.ReframeDeprecationWarning --rfm-user-config=config/cscs-${backend}.py
done
export PATH=$PATH_save
fi
Expand Down
2 changes: 1 addition & 1 deletion unittests/resources/checks/frontend_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def __init__(self):


@rfm.simple_test
class CustomPerformanceFailureCheck(BaseFrontendCheck):
class CustomPerformanceFailureCheck(BaseFrontendCheck, special=True):
'''Simulate a performance check that ignores completely logging'''

def __init__(self):
Expand Down
2 changes: 1 addition & 1 deletion unittests/resources/checks_unlisted/selfkill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@


@rfm.simple_test
class SelfKillCheck(rfm.RunOnlyRegressionTest):
class SelfKillCheck(rfm.RunOnlyRegressionTest, special=True):
def __init__(self):
self.local = True
self.valid_systems = ['*']
Expand Down