Skip to content

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented May 5, 2020

Closes #1212

@rsarm rsarm added this to the ReFrame sprint 20.07 milestone May 5, 2020
@rsarm rsarm requested review from ekouts and vkarak May 5, 2020 16:44
@rsarm rsarm self-assigned this May 5, 2020
@codecov-io
Copy link

codecov-io commented May 5, 2020

Codecov Report

Merging #1292 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1292   +/-   ##
=======================================
  Coverage   91.31%   91.31%           
=======================================
  Files          84       84           
  Lines       12546    12548    +2     
=======================================
+ Hits        11456    11458    +2     
  Misses       1090     1090           
Impacted Files Coverage Δ
unittests/test_schedulers.py 95.43% <ø> (ø)
reframe/core/schedulers/pbs.py 68.60% <100.00%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68e2f88...823d66e. Read the comment docs.

Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you have branched from an older master, therefore the conflicts. Since the unit tests have changed dramatically and you're adding a single line, I'd discourage your from merging and trying to resolve the conflicts. Instead, revert your change in test_schedulers.py, merge with master, then reapply manually your change in the corresponding unit test.

@vkarak
Copy link
Contributor

vkarak commented May 25, 2020

@rsarm Can you fix this PR as well so that we can merge it?

@vkarak vkarak removed this from the ReFrame sprint 20.08 milestone May 26, 2020
@vkarak
Copy link
Contributor

vkarak commented Jun 2, 2020

Closing this, no more needed due to #1338.

@vkarak vkarak closed this Jun 2, 2020
@rsarm rsarm deleted the feat/pbs-account branch March 10, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable job account option for the Torque backend

4 participants