-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Enable job account option for the PBS backend #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1292 +/- ##
=======================================
Coverage 91.31% 91.31%
=======================================
Files 84 84
Lines 12546 12548 +2
=======================================
+ Hits 11456 11458 +2
Misses 1090 1090
Continue to review full report at Codecov.
|
ekouts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you have branched from an older master, therefore the conflicts. Since the unit tests have changed dramatically and you're adding a single line, I'd discourage your from merging and trying to resolve the conflicts. Instead, revert your change in test_schedulers.py, merge with master, then reapply manually your change in the corresponding unit test.
|
@rsarm Can you fix this PR as well so that we can merge it? |
|
Closing this, no more needed due to #1338. |
Closes #1212