-
Notifications
You must be signed in to change notification settings - Fork 117
[test] New Slurm setup for Cp2kGpuCheck #1304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @lucamar, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2020-06-09 21:12:30 UTC |
|
@jenkins-cscs retry dom |
|
The check on |
|
@jenkins-cscs retry dom |
|
No chance to have 6 |
|
Hi @lucamar, is this setup valid also for the default CP2K version? If yes, I would suggest to keep the default module and invoke reframe with |
|
@vkarak Thanks for your comment: yes, the new setup is also valid for the current default module. |
Reverting back to default CP2K modulefile for gpu and mc checks
|
@lucamar What if we parametrized the test on the module name? |
Codecov Report
@@ Coverage Diff @@
## master #1304 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 83 83
Lines 12673 12673
=======================================
Hits 11617 11617
Misses 1056 1056 Continue to review full report at Codecov.
|
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I propose to run the
Cp2kGpuCheckwith 6 tasks per node and 2 cpus per task, as it is slightly more efficient with respect to the current Slurm setup.I would also like to test the
CP2Kmodules recently provided with the latest stable release 7.1: however, the new modules are not yet default.Should we change directly the modules loaded in the existing checks or should we rather create a new set of checks for the new versions with a new variant (e.g.
dev) and keep the existing ones for the default modules only?The latter would be probably a better solution to keep track of the performance of the new vs. old release of applications: the new variant would result in having
Cp2kCpuCheck_small_dev, etc...Please let me know your opinion and I would adjust the checks accordingly.