Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented May 26, 2020

Fixes #1269

@teojgo teojgo added this to the ReFrame sprint 20.08 milestone May 26, 2020
@teojgo teojgo requested review from victorusu and vkarak May 26, 2020 09:58
@teojgo teojgo self-assigned this May 26, 2020
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm except that we should still keep the old attributes and deprecate them! With fields it's pretty simple to do.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix these. I will do some minor fixes to the documentation as well.

@codecov-commenter
Copy link

Codecov Report

Merging #1336 into master will increase coverage by 0.00%.
The diff coverage is 96.15%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1336   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files          83       83           
  Lines       12561    12565    +4     
=======================================
+ Hits        11529    11533    +4     
  Misses       1032     1032           
Impacted Files Coverage Δ
reframe/utility/color.py 100.00% <ø> (ø)
reframe/core/pipeline.py 92.89% <92.85%> (+0.05%) ⬆️
unittests/resources/checks/frontend_checks.py 99.34% <100.00%> (ø)
unittests/resources/checks_unlisted/good.py 87.87% <100.00%> (ø)
unittests/test_pipeline.py 94.08% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13cb6a...bfa12cc. Read the comment docs.

@vkarak
Copy link
Contributor

vkarak commented May 29, 2020

@teojgo After we merged with master, the unit tests fail because of two deprecation warnings:

=============================================================================================== warnings summary ===============================================================================================
unittests/test_policies.py::test_compile_fail_reschedule_main_loop
unittests/test_policies.py::test_compile_fail_reschedule_busy_loop
  /Users/karakasv/Repositories/reframe/unittests/resources/checks/frontend_checks.py:232: ReframeDeprecationWarning: 'prebuild_cmd' is deprecated; please use 'prebuild_cmds' instead
    self.prebuild_cmd = ['echo foo > x.c']

-- Docs: https://docs.pytest.org/en/latest/warnings.html

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix deprecation warnings in unit tests.

@vkarak vkarak merged commit c6708be into reframe-hpc:master May 29, 2020
@teojgo teojgo deleted the feat/unify_naming_conv branch June 26, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify the naming convention of pre/post_run and pre/post_build_cmd commands

3 participants