-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Unify the names of pre/postrun and pre/postbuild cmds #1336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm except that we should still keep the old attributes and deprecate them! With fields it's pretty simple to do.
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fix these. I will do some minor fixes to the documentation as well.
Codecov Report
@@ Coverage Diff @@
## master #1336 +/- ##
=======================================
Coverage 91.78% 91.78%
=======================================
Files 83 83
Lines 12561 12565 +4
=======================================
+ Hits 11529 11533 +4
Misses 1032 1032
Continue to review full report at Codecov.
|
|
@teojgo After we merged with master, the unit tests fail because of two deprecation warnings: |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to fix deprecation warnings in unit tests.
Fixes #1269