Skip to content

[feat] Replace scheduler-specific command-line options #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 29, 2020
Merged

[feat] Replace scheduler-specific command-line options #1338

merged 8 commits into from
May 29, 2020

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented May 26, 2020

Closes #486

@rsarm rsarm added this to the ReFrame sprint 20.08 milestone May 26, 2020
@rsarm rsarm requested review from ekouts and vkarak May 26, 2020 16:12
@rsarm rsarm self-assigned this May 26, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020 •
edited
Loading

Codecov Report

Merging #1338 into master will decrease coverage by 0.06%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1338      +/-   ##
==========================================
- Coverage   91.72%   91.65%   -0.07%     
==========================================
  Files          83       83              
  Lines       12578    12595      +17     
==========================================
+ Hits        11537    11544       +7     
- Misses       1041     1051      +10
Impacted Files Coverage Δ
reframe/frontend/cli.py 77.57% <44.44%> (-1.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6708be...19e84ed. Read the comment docs.

@ekouts ekouts mentioned this pull request May 27, 2020
Closed
@ekouts
Copy link
Contributor

ekouts commented May 27, 2020

@jenkins-cscs retry all

ekouts
ekouts requested changes May 27, 2020
View reviewed changes
Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add some unittests and maybe a comment on the documentation here about the different ways you can pass the options to --job-option.

vkarak
vkarak requested changes May 27, 2020
View reviewed changes
@vkarak
Copy link
Contributor

vkarak commented May 27, 2020

I agree with @ekouts. Documentation of the -J option must be elaborated. I don't know what kind of unit tests we could add though.

vkarak
vkarak requested changes May 29, 2020
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, overall. I just have a couple of minor comments.

@vkarak vkarak requested a review from ekouts May 29, 2020 11:33
@vkarak vkarak merged commit 0360a7e into reframe-hpc:master May 29, 2020
@ekouts ekouts mentioned this pull request Jun 2, 2020
Closed
This was referenced Jun 2, 2020
Closed
Closed
@rsarm rsarm deleted the feat/sched-specific-cli branch March 10, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@ekouts ekouts ekouts approved these changes

Assignees

@rsarm rsarm

Labels

prio: normal request for enhancement

Projects

None yet

Milestone

ReFrame sprint 20.08

Development

Successfully merging this pull request may close these issues.

Replace scheduler-specific command-line options

4 participants

@rsarm @codecov-commenter @ekouts @vkarak