Skip to content

[feat] Add node list information for jobs submitted with the Torque backend #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 3, 2020
Merged

[feat] Add node list information for jobs submitted with the Torque backend #1347

merged 6 commits into from
Jun 3, 2020

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented May 29, 2020

Close #1213

@rsarm rsarm added this to the ReFrame sprint 20.08 milestone May 29, 2020
@rsarm rsarm requested review from teojgo and vkarak May 29, 2020 08:19
@rsarm rsarm self-assigned this May 29, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2020 •
edited
Loading

Codecov Report

Merging #1347 into master will decrease coverage by 0.05%.
The diff coverage is 10.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1347      +/-   ##
==========================================
- Coverage   91.65%   91.60%   -0.06%     
==========================================
  Files          83       83              
  Lines       12599    12608       +9     
==========================================
+ Hits        11548    11549       +1     
- Misses       1051     1059       +8
Impacted Files Coverage Δ
unittests/test_schedulers.py 91.66% <0.00%> (ø)
reframe/core/schedulers/torque.py 27.27% <11.11%> (-3.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e0c1cd...6279b44. Read the comment docs.

vkarak
vkarak requested changes May 29, 2020
View reviewed changes
vkarak
vkarak requested changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also extend the test_submit() unit test here to enable pbs and torque.

vkarak
vkarak approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit aa62399 into reframe-hpc:master Jun 3, 2020
@rsarm rsarm deleted the feat/nodelist-torque branch March 10, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@teojgo teojgo Awaiting requested review from teojgo

Assignees

@rsarm rsarm

Labels

prio: normal request for enhancement

Projects

None yet

Milestone

ReFrame sprint 20.08

Development

Successfully merging this pull request may close these issues.

Get node list information for jobs submitted with the Torque backend

3 participants

@rsarm @codecov-commenter @vkarak