Skip to content

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented Jun 4, 2020

No description provided.

@rsarm rsarm requested review from twrobinson and vkarak June 4, 2020 08:01
@rsarm rsarm self-assigned this Jun 4, 2020
@pep8speaks
Copy link

pep8speaks commented Jun 4, 2020

Hello @rsarm, Thank you for updating!

Line 27:80: E501 line too long (100 > 79 characters)
Line 31:80: E501 line too long (119 > 79 characters)
Line 35:80: E501 line too long (318 > 79 characters)
Line 37:80: E501 line too long (396 > 79 characters)
Line 39:80: E501 line too long (390 > 79 characters)
Line 41:80: E501 line too long (87 > 79 characters)
Line 43:80: E501 line too long (559 > 79 characters)
Line 45:80: E501 line too long (102 > 79 characters)

Do see the ReFrame Coding Style Guide

Comment last updated at 2020-06-15 14:59:53 UTC

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2020

Codecov Report

Merging #1360 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1360   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files          83       83           
  Lines       12673    12673           
=======================================
  Hits        11617    11617           
  Misses       1056     1056           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a7e9a5...b8585f6. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a small comment about the module unload dask. Other than that lgtm.

@vkarak
Copy link
Contributor

vkarak commented Jun 12, 2020

@jenkins-cscs retry daint

@vkarak
Copy link
Contributor

vkarak commented Jun 15, 2020

@jenkins-cscs retry daint tsa

@vkarak vkarak merged commit 1f97a38 into reframe-hpc:master Jun 15, 2020
@rsarm rsarm deleted the check/ipcmagic branch March 10, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants