Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Jun 13, 2020

Fixes #1362.

@vkarak vkarak added this to the ReFrame sprint 20.09 milestone Jun 13, 2020
@vkarak vkarak requested a review from ekouts June 13, 2020 23:20
@vkarak vkarak self-assigned this Jun 13, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2020

Codecov Report

Merging #1373 into master will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1373      +/-   ##
==========================================
- Coverage   91.66%   91.66%   -0.01%     
==========================================
  Files          83       83              
  Lines       12673    12675       +2     
==========================================
+ Hits        11617    11618       +1     
- Misses       1056     1057       +1     
Impacted Files Coverage Δ
reframe/core/meta.py 96.77% <50.00%> (-3.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a7e9a5...ffc64d7. Read the comment docs.

Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit 42065b9 into reframe-hpc:master Jun 15, 2020
@vkarak vkarak deleted the bugfix/attributeerror-final-methods branch June 15, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

monkeypatching in e.g. run_before() methods

3 participants