Skip to content

[test] Fix deprecation warning in IPCMagicCheck #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2020
Merged

[test] Fix deprecation warning in IPCMagicCheck #1387

merged 2 commits into from
Jun 25, 2020

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Jun 23, 2020

Replace pre_run with prerun_cmds

@ekouts ekouts requested a review from vkarak June 23, 2020 15:42
@ekouts ekouts self-assigned this Jun 23, 2020
@ekouts
Copy link
Contributor Author

ekouts commented Jun 24, 2020

@jenkins-cscs retry daint

vkarak
vkarak approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak added this to the ReFrame sprint 20.10 milestone Jun 25, 2020
@vkarak
Copy link
Contributor

vkarak commented Jun 25, 2020

@jenkins-cscs retry kesch

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2020 •
edited
Loading

Codecov Report

Merging #1387 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1387   +/-   ##
=======================================
  Coverage   91.75%   91.75%           
=======================================
  Files          83       83           
  Lines       12712    12712           
=======================================
  Hits        11664    11664           
  Misses       1048     1048

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb7d4f...a5e3cdf. Read the comment docs.

@vkarak vkarak merged commit bedc3b0 into reframe-hpc:master Jun 25, 2020
@ekouts ekouts deleted the test/ipcmagic_deprecation_warning branch August 25, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

Assignees

@ekouts ekouts

Labels

enhancement

Projects

None yet

Milestone

ReFrame sprint 20.10

Development

Successfully merging this pull request may close these issues.

3 participants

@ekouts @vkarak @codecov-commenter