[bugfix] Add missing launchers upcrun and upcxx-run in configuration schema
#1393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can I test this patch? |
Codecov Report
@@ Coverage Diff @@
## master #1393 +/- ##
==========================================
+ Coverage 91.66% 91.75% +0.08%
==========================================
Files 83 83
Lines 12673 12712 +39
==========================================
+ Hits 11617 11664 +47
+ Misses 1056 1048 -8
Continue to review full report at Codecov.
|
vkarak
changed the title
upcrun and upcxx-runupcrun and upcxx-run in configuration schema
vkarak
approved these changes
Jun 28, 2020
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
Thanks @bcfriesen for the fix!
Contributor
|
ok to test |
ekouts
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReFrame 3 upstreamed support for UPC and UPC++ launchers from Berkeley Lab. This PR fixes a missed change to the launcher schemes. Without this, tests which request the
upcrunorupcxx-runlaunchers will fail because ReFrame cannot find them in this list.