Skip to content

Conversation

@ChristopherBignamini
Copy link
Contributor

@ChristopherBignamini ChristopherBignamini commented Jul 7, 2020

Addresses UES-845
Addresses UES-925

@pep8speaks
Copy link

pep8speaks commented Jul 7, 2020

Hello @ChristopherBignamini, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2020-07-18 07:08:12 UTC

@victorusu victorusu requested review from victorusu and vkarak July 7, 2020 14:31
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ChristopherBignamini
Copy link
Contributor Author

@jenkins-cscs retry dom

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2020

Codecov Report

Merging #1403 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1403   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files          82       82           
  Lines       12786    12786           
=======================================
  Hits        11742    11742           
  Misses       1044     1044           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f53604b...7270362. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a couple of style fixes, which I will do myself.

@vkarak vkarak added this to the ReFrame sprint 20.11 milestone Jul 16, 2020
Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit f6111d7 into reframe-hpc:master Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants