[feat] Add option to disable test stage directory cleanup #1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 7, 2020 18:43
To better support this, the `os_ext.copytree()` was rewritten to comply with the `dirs_exist_ok` argument added in Python 3.8
Plus a minor fix in the implementation along with unit test adaptation.
Codecov Report
@@ Coverage Diff @@
## master #1404 +/- ##
==========================================
+ Coverage 91.77% 91.79% +0.01%
==========================================
Files 83 83
Lines 12708 12743 +35
==========================================
+ Hits 11663 11697 +34
- Misses 1045 1046 +1
Continue to review full report at Codecov.
|
Contributor
Author
|
@jenkins-cscs retry daint kesch |
Contributor
Author
|
@jenkins-cscs retry none |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past we removed the stage directory of a test in two places. Inside the
RuntimeContextand inside and low-levelos_ext.copytree()function. We have changedcopytree()and made it completely compatible with Python 3.8, which has added thedirs_exist_okargument. It does not remove the target directory if it exists, as it was the previous version. Responsible for removing the stage directory is only theRuntimeContext.I want some feedback about the name of the command-line option and the naming of the configuration option as well.
Fixes #1366.