Skip to content

[bugfix] Copy scheduler options when initializing job instances #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2020
Merged

[bugfix] Copy scheduler options when initializing job instances #1413

merged 2 commits into from
Jul 13, 2020

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Jul 13, 2020

Fixes #1412

@teojgo teojgo added this to the ReFrame sprint 20.11 milestone Jul 13, 2020
@teojgo teojgo requested review from ekouts and vkarak July 13, 2020 09:58
@teojgo teojgo self-assigned this Jul 13, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2020 •
edited
Loading

Codecov Report

Merging #1413 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1413   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files          83       83           
  Lines       12743    12743           
=======================================
  Hits        11697    11697           
  Misses       1046     1046
Impacted Files Coverage Δ
reframe/core/schedulers/__init__.py 98.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83cb21...f24848b. Read the comment docs.

ekouts
ekouts approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [bugfix] Copy 'sched_options' when initializing a 'Job' instance [bugfix] Copy scheduler options when initializing job instances Jul 13, 2020
vkarak
vkarak approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit 1e0f3ee into reframe-hpc:master Jul 13, 2020
@teojgo teojgo deleted the bugfix/copy_sched_options branch October 23, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@ekouts ekouts ekouts approved these changes

Assignees

@teojgo teojgo

Labels

bugfix

Projects

None yet

Milestone

ReFrame sprint 20.11

Development

Successfully merging this pull request may close these issues.

Changes in self.job.options are inheritted in subsequent tests

4 participants

@teojgo @codecov-commenter @vkarak @ekouts