Skip to content

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Jul 23, 2020

Besides _running_tasks and _waiting_tasks, we can have a more strict check in the async policy main loop. In this way we make sure that the tasks will run in the correct reframe "retry".

I couldn't find how to reproduce the bug, but it should fix #1398 .

@ekouts ekouts added this to the ReFrame sprint 20.11 milestone Jul 23, 2020
@ekouts ekouts requested a review from vkarak July 23, 2020 12:16
@ekouts ekouts self-assigned this Jul 23, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2020

Codecov Report

Merging #1434 into master will decrease coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
- Coverage   91.83%   91.54%   -0.30%     
==========================================
  Files          82       82              
  Lines       12798    12365     -433     
==========================================
- Hits        11753    11319     -434     
- Misses       1045     1046       +1     
Impacted Files Coverage Δ
reframe/frontend/executors/policies.py 98.23% <100.00%> (+0.01%) ⬆️
...tests/resources/checks_unlisted/deprecated_test.py 53.84% <0.00%> (-3.30%) ⬇️
reframe/core/systems.py 86.06% <0.00%> (-2.13%) ⬇️
reframe/core/modules.py 60.51% <0.00%> (-1.93%) ⬇️
unittests/test_launchers.py 93.54% <0.00%> (-1.39%) ⬇️
unittests/test_environments.py 72.07% <0.00%> (-1.22%) ⬇️
reframe/core/deferrable.py 96.62% <0.00%> (-0.88%) ⬇️
reframe/core/exceptions.py 85.07% <0.00%> (-0.75%) ⬇️
reframe/core/environments.py 95.00% <0.00%> (-0.66%) ⬇️
reframe/core/schedulers/slurm.py 56.94% <0.00%> (-0.61%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c027bc7...8f99238. Read the comment docs.

@ekouts
Copy link
Contributor Author

ekouts commented Jul 24, 2020

@jenkins-cscs retry all

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [bugfix] Improve check in the exit loop of async policy [bugfix] More complete check in the exit loop of the asynchronous execution policy Jul 24, 2020
@vkarak vkarak changed the title [bugfix] More complete check in the exit loop of the asynchronous execution policy [bugfix] Capture all pending test tasks in the exit loop of the asynchronous execution policy Jul 24, 2020
@vkarak vkarak merged commit 69afc67 into reframe-hpc:master Jul 24, 2020
@ekouts ekouts deleted the bugfix/async_policy_loop branch August 25, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in numbering during retries encountered

3 participants