-
Notifications
You must be signed in to change notification settings - Fork 117
[bugfix] Capture all pending test tasks in the exit loop of the asynchronous execution policy #1434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1434 +/- ##
==========================================
- Coverage 91.83% 91.54% -0.30%
==========================================
Files 82 82
Lines 12798 12365 -433
==========================================
- Hits 11753 11319 -434
- Misses 1045 1046 +1
Continue to review full report at Codecov.
|
|
@jenkins-cscs retry all |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Besides
_running_tasksand_waiting_tasks, we can have a more strict check in the async policy main loop. In this way we make sure that the tasks will run in the correct reframe "retry".I couldn't find how to reproduce the bug, but it should fix #1398 .