Skip to content

[bugfix] Capture all pending test tasks in the exit loop of the asynchronous execution policy #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 24, 2020
Merged

[bugfix] Capture all pending test tasks in the exit loop of the asynchronous execution policy #1434

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
532b4db
Improve check in the loop of async policy
ekouts Jul 23, 2020
783c5b8
Improve check in the loop of async policy
ekouts Jul 23, 2020
63e58d0
add values_len function
ekouts Jul 23, 2020
8f99238
rename values_len to dictlist_len
ekouts Jul 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion reframe/frontend/executors/policies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# SPDX-License-Identifier: BSD-3-Clause

import contextlib
import functools
import itertools
import math
import sys
Expand All @@ -17,6 +18,10 @@
TaskEventListener, ABORT_REASONS)


def dictlist_len(d):
return functools.reduce(lambda l, r: l + len(r), d.values(), 0)


def _cleanup_all(tasks, *args, **kwargs):
for task in tasks:
if task.ref_count == 0:
Expand Down Expand Up @@ -416,7 +421,8 @@ def exit(self):
pollrate = PollRateFunction(0.2, 60)
num_polls = 0
t_start = datetime.now()
while (self._running_tasks or self._waiting_tasks):
while (self._running_tasks or self._waiting_tasks or
self._completed_tasks or dictlist_len(self._ready_tasks)):
getlogger().debug('running tasks: %s' % len(self._running_tasks))
num_polls += len(self._running_tasks)
try:
Expand Down