Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Sep 18, 2020

  • The import_module_from_file function is now aware
    of modules istalled under site-packages or dist-packages.

Fixes #1465

* The `import_module_from_file` function is now aware
  of modules istalled under `site-packages` or `dist-packages`.
@teojgo teojgo added this to the ReFrame sprint 20.13 milestone Sep 18, 2020
@teojgo teojgo requested review from victorusu and vkarak September 18, 2020 14:12
@teojgo teojgo self-assigned this Sep 18, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2020

Codecov Report

Merging #1488 into master will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1488      +/-   ##
==========================================
- Coverage   91.72%   91.71%   -0.01%     
==========================================
  Files          82       82              
  Lines       12924    12928       +4     
==========================================
+ Hits        11854    11857       +3     
- Misses       1070     1071       +1     
Impacted Files Coverage Δ
reframe/utility/__init__.py 92.97% <75.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c1f771...434dd24. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [bugfix] Fix module name extraction under 'site-packages' [bugfix] Fix module import for files under site-packages Sep 18, 2020
@vkarak vkarak merged commit 0e59de1 into reframe-hpc:master Sep 18, 2020
@teojgo teojgo deleted the bugfix/import_module_from_file branch October 23, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reframe.core.exceptions.ConfigError: ... No module named 'lib.python3'

3 participants