Skip to content

Conversation

@jgphpc
Copy link
Contributor

@jgphpc jgphpc commented Sep 18, 2020

Will fix #1196

@jgphpc jgphpc requested a review from vkarak September 18, 2020 16:21
@jgphpc jgphpc self-assigned this Sep 18, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2020

Codecov Report

Merging #1490 into master will increase coverage by 0.07%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1490      +/-   ##
==========================================
+ Coverage   91.65%   91.72%   +0.07%     
==========================================
  Files          83       83              
  Lines       13012    13029      +17     
==========================================
+ Hits        11926    11951      +25     
+ Misses       1086     1078       -8     
Impacted Files Coverage Δ
reframe/core/pipeline.py 92.87% <88.88%> (+0.06%) ⬆️
unittests/test_pipeline.py 95.19% <100.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8889c9...a252634. Read the comment docs.

@vkarak vkarak added this to the ReFrame sprint 20.13 milestone Sep 18, 2020
@vkarak vkarak changed the title Add ignore_exit_code configuration parameter [feat] Add ignore_exit_code configuration parameter Sep 18, 2020
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will also need a unit test.

@vkarak vkarak changed the title [feat] Add ignore_exit_code configuration parameter [feat] Add configuration parameter for automatically capturing command errors and exit code in job scripts Sep 25, 2020
@victorusu
Copy link
Contributor

victorusu commented Oct 2, 2020

Does it make sense to allow the check to bypass this configuration? Something like

self.trap_job_errors = False

The use case is when one needs to write a check where one expects a command to exit code different than zero, while the default config is set to trap_job_errors=True.
In this case, this check cannot be executed together with other checks, it needs a different ReFrame invocation.

@vkarak
Copy link
Contributor

vkarak commented Oct 2, 2020

@victorusu I would see it as a job parameter rather than a test parameter. I'm generally against bloating either API, though, unless we need to. If that comes as a feature request from a real scenario, then we can discuss it again.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

@vkarak vkarak merged commit 068dccb into reframe-hpc:master Oct 2, 2020
@jgphpc jgphpc deleted the gh_1196 branch October 7, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verify exit code of tests

4 participants