Skip to content

[bugfix] Load configuration even if the username cannot be retrieved #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 28, 2020
Merged

[bugfix] Load configuration even if the username cannot be retrieved #1499

merged 4 commits into from
Sep 28, 2020

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Sep 24, 2020

Fixes #1496

@teojgo teojgo added this to the ReFrame sprint 20.14 milestone Sep 24, 2020
@teojgo teojgo requested review from ekouts and vkarak September 24, 2020 15:03
@teojgo teojgo self-assigned this Sep 24, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2020 •
edited
Loading

Codecov Report

Merging #1499 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1499      +/-   ##
==========================================
+ Coverage   91.57%   91.65%   +0.07%     
==========================================
  Files          83       83              
  Lines       13002    13012      +10     
==========================================
+ Hits        11907    11926      +19     
+ Misses       1095     1086       -9
Impacted Files Coverage Δ
reframe/core/config.py 90.77% <100.00%> (+2.15%) ⬆️
unittests/test_config.py 100.00% <100.00%> (ø)
reframe/utility/os_ext.py 91.91% <0.00%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8d5ed5...f43ea92. Read the comment docs.

vkarak
vkarak requested changes Sep 25, 2020
View reviewed changes
@pep8speaks
Copy link

pep8speaks commented Sep 28, 2020 •
edited
Loading

Hello @teojgo, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2020-09-28 19:52:20 UTC

vkarak
vkarak approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [bugfix] Use 'getpass.getuser()' to find the user config [bugfix] Load configuration even if the username cannot be retrieved Sep 28, 2020
@vkarak vkarak merged commit 3c8f324 into reframe-hpc:master Sep 28, 2020
@teojgo teojgo deleted the bugfix/getuser branch October 23, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@ekouts ekouts Awaiting requested review from ekouts

Assignees

@teojgo teojgo

Labels

bugfix prio: normal

Projects

None yet

Milestone

ReFrame sprint 20.14

Development

Successfully merging this pull request may close these issues.

Reframe fails to perform actions when no configuration is passed

4 participants

@teojgo @codecov-commenter @pep8speaks @vkarak