Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Oct 6, 2020

Fixes #1453.

@vkarak vkarak added this to the ReFrame sprint 20.14 milestone Oct 6, 2020
@vkarak vkarak requested a review from teojgo October 6, 2020 19:34
@vkarak vkarak self-assigned this Oct 6, 2020
@vkarak
Copy link
Contributor Author

vkarak commented Oct 7, 2020

@jenkins-cscs retry daint

Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comments that you have posted I have tested and it looks good.

@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@84ce07d). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1508   +/-   ##
=========================================
  Coverage          ?   91.51%           
=========================================
  Files             ?       83           
  Lines             ?    13198           
  Branches          ?        0           
=========================================
  Hits              ?    12078           
  Misses            ?     1120           
  Partials          ?        0           
Impacted Files Coverage Δ
reframe/core/config.py 90.82% <100.00%> (ø)
reframe/core/systems.py 88.31% <100.00%> (ø)
reframe/frontend/cli.py 79.60% <100.00%> (ø)
unittests/test_config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84ce07d...ace5eda. Read the comment docs.

@vkarak vkarak merged commit 099789b into reframe-hpc:master Oct 7, 2020
@vkarak vkarak deleted the bugfix/default-env-required branch October 7, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default environment is required

3 participants