Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Oct 12, 2020

Fixes #1522

@teojgo teojgo added this to the ReFrame sprint 20.15 milestone Oct 12, 2020
@teojgo teojgo requested review from victorusu and vkarak October 12, 2020 11:49
@teojgo teojgo self-assigned this Oct 12, 2020
@codecov-io
Copy link

codecov-io commented Oct 12, 2020

Codecov Report

Merging #1529 into master will increase coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1529      +/-   ##
==========================================
+ Coverage   87.37%   87.90%   +0.53%     
==========================================
  Files          43       43              
  Lines        6558     6848     +290     
==========================================
+ Hits         5730     6020     +290     
  Misses        828      828              
Impacted Files Coverage Δ
reframe/utility/color.py 100.00% <0.00%> (ø)
reframe/core/containers.py 100.00% <0.00%> (ø)
reframe/frontend/cli.py 79.61% <0.00%> (+<0.01%) ⬆️
reframe/core/buildsystems.py 97.11% <0.00%> (+0.01%) ⬆️
reframe/utility/__init__.py 91.55% <0.00%> (+0.05%) ⬆️
reframe/core/decorators.py 96.90% <0.00%> (+0.06%) ⬆️
reframe/frontend/executors/__init__.py 98.69% <0.00%> (+0.09%) ⬆️
reframe/frontend/argparse.py 92.30% <0.00%> (+0.12%) ⬆️
reframe/core/config.py 90.82% <0.00%> (+0.13%) ⬆️
reframe/core/schedulers/local.py 95.83% <0.00%> (+0.18%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b37509...295f289. Read the comment docs.

@teojgo teojgo changed the title [feat] Add cli option to install optional python packages [feat] Add cli option to install pygelf in boostrap script Oct 13, 2020
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [feat] Add cli option to install pygelf in boostrap script [feat] Add option to install pygelf in boostrap script Oct 19, 2020
@vkarak vkarak merged commit 02c7bfb into reframe-hpc:master Oct 19, 2020
@teojgo teojgo deleted the feat/bootstrap_optional_packages branch October 23, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to install pygelf when executing the bootstrap.sh

3 participants