Skip to content

Conversation

@jonathanfrawley
Copy link
Contributor

A system I am working on uses version numbers such as "3.2.1+26-ad12ae47" for the module environment. This breaks reframe, but since reframe only looks at the major and minor numbers, it is not required to parse out the bugfix version at all.

@jenkins-cscs
Copy link
Collaborator

Can I test this patch?

@vkarak vkarak requested review from victorusu and vkarak October 16, 2020 17:02
@vkarak vkarak self-assigned this Oct 16, 2020
@vkarak vkarak changed the title Fix bug when bugfix version is not an integer [bugfix] Fix bug when bugfix version is not an integer Oct 16, 2020
@codecov-io
Copy link

codecov-io commented Oct 16, 2020

Codecov Report

Merging #1540 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1540   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files          43       43           
  Lines        6848     6848           
=======================================
  Hits         6020     6020           
  Misses        828      828           
Impacted Files Coverage Δ
reframe/core/modules.py 60.36% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a567e70...170d505. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jonathanfrawley, thanks for the PR and the fix. We will also need a unit test to reproduce the bug. I can provide one.

@vkarak vkarak changed the title [bugfix] Fix bug when bugfix version is not an integer [bugfix] Fix bug when patchlevel in modules version is not an integer Oct 20, 2020
@vkarak
Copy link
Contributor

vkarak commented Oct 20, 2020

Hi @jonathanfrawley, thanks for the PR and the fix. We will also need a unit test to reproduce the bug. I can provide one.

Ignore my comment about the unit tests. I just realised it was in the way we initialize the modules backend, so it should be fine if you just address my other comment.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxsplit=2 won't work, so lgtm as it is now.

@vkarak
Copy link
Contributor

vkarak commented Oct 20, 2020

ok to test

Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [bugfix] Fix bug when patchlevel in modules version is not an integer [bugfix] Fix bug when patchlevel in environment modules version is not an integer Oct 20, 2020
@vkarak
Copy link
Contributor

vkarak commented Oct 20, 2020

@jenkins-cscs retry tsa

@vkarak vkarak merged commit be9de13 into reframe-hpc:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants