-
Notifications
You must be signed in to change notification settings - Fork 117
[bugfix] Fix bug when patchlevel in environment modules version is not an integer #1540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can I test this patch? |
Codecov Report
@@ Coverage Diff @@
## master #1540 +/- ##
=======================================
Coverage 87.90% 87.90%
=======================================
Files 43 43
Lines 6848 6848
=======================================
Hits 6020 6020
Misses 828 828
Continue to review full report at Codecov.
|
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jonathanfrawley, thanks for the PR and the fix. We will also need a unit test to reproduce the bug. I can provide one.
Ignore my comment about the unit tests. I just realised it was in the way we initialize the modules backend, so it should be fine if you just address my other comment. |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maxsplit=2 won't work, so lgtm as it is now.
|
ok to test |
victorusu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@jenkins-cscs retry tsa |
A system I am working on uses version numbers such as "3.2.1+26-ad12ae47" for the module environment. This breaks reframe, but since reframe only looks at the major and minor numbers, it is not required to parse out the bugfix version at all.