Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Oct 22, 2020

Also:

  • Move all the warning related parts into a separate file.
  • In order to achieve the coloration of the full message, we had to replace the warning formatting method. Also the message is adjusted.

Fixes #1267.

@vkarak vkarak added this to the ReFrame sprint 20.15 milestone Oct 22, 2020
@vkarak vkarak requested review from ekouts and teojgo October 22, 2020 22:57
@vkarak vkarak self-assigned this Oct 22, 2020
Also:

- Move all the warning related parts into a separate file.
@vkarak vkarak force-pushed the feat/color-deprecation-warnings branch from 2a7e535 to e8a85ad Compare October 22, 2020 22:58
@codecov-io
Copy link

codecov-io commented Oct 23, 2020

Codecov Report

Merging #1549 into master will decrease coverage by 0.16%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1549      +/-   ##
==========================================
- Coverage   87.94%   87.77%   -0.17%     
==========================================
  Files          43       44       +1     
  Lines        6842     6863      +21     
==========================================
+ Hits         6017     6024       +7     
- Misses        825      839      +14     
Impacted Files Coverage Δ
reframe/core/deferrable.py 97.51% <ø> (-0.02%) ⬇️
reframe/core/exceptions.py 89.23% <ø> (-0.77%) ⬇️
reframe/core/systems.py 88.31% <0.00%> (ø)
reframe/core/warnings.py 51.72% <51.72%> (ø)
reframe/core/config.py 90.85% <100.00%> (+0.02%) ⬆️
reframe/core/fields.py 98.98% <100.00%> (ø)
reframe/core/meta.py 96.96% <100.00%> (ø)
reframe/core/pipeline.py 92.43% <100.00%> (+0.01%) ⬆️
reframe/frontend/cli.py 79.67% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d531e0...30dfc63. Read the comment docs.

@vkarak
Copy link
Contributor Author

vkarak commented Oct 23, 2020

I need to add a unit test to check the formatting of the deprecation warning: https://codecov.io/gh/eth-cscs/reframe/pull/1549/diff?src=pr&el=tree#diff-cmVmcmFtZS9jb3JlL3dhcm5pbmdzLnB5

@vkarak
Copy link
Contributor Author

vkarak commented Oct 25, 2020

@jenkins-cscs retry tsa

Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine now.

@vkarak
Copy link
Contributor Author

vkarak commented Oct 26, 2020

@jenkins-cscs retry all

@vkarak vkarak merged commit 7c22acc into reframe-hpc:master Oct 26, 2020
@vkarak vkarak deleted the feat/color-deprecation-warnings branch October 26, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow coloring of deprecation warnings

4 participants