-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Color deprecation warnings #1549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Color deprecation warnings #1549
Conversation
Also: - Move all the warning related parts into a separate file.
2a7e535 to
e8a85ad
Compare
Codecov Report
@@ Coverage Diff @@
## master #1549 +/- ##
==========================================
- Coverage 87.94% 87.77% -0.17%
==========================================
Files 43 44 +1
Lines 6842 6863 +21
==========================================
+ Hits 6017 6024 +7
- Misses 825 839 +14
Continue to review full report at Codecov.
|
|
I need to add a unit test to check the formatting of the deprecation warning: https://codecov.io/gh/eth-cscs/reframe/pull/1549/diff?src=pr&el=tree#diff-cmVmcmFtZS9jb3JlL3dhcm5pbmdzLnB5 |
|
@jenkins-cscs retry tsa |
ekouts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
teojgo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine now.
|
@jenkins-cscs retry all |
Also:
Fixes #1267.