Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Nov 3, 2020

  • The initialization of the framework and the loading of checks is much better logged now. The test loading and filtering is logged at the verbose level.
  • A new debug level, DEBUG2, was introduced. All messages from the execution policies and the actual OS commands that are being executed are logged in this level.
  • The default level for the logger objects is now set to "undefined." This allows for the seamless addition of new debug levels in the future.
  • The stdout and stderr markers in errors for spawned processes have changed.

Fixes #1046.

It also addresses #795, since by increasing verbosity you can now see what files are being loaded and how many tests.

Vasileios Karakasis added 3 commits November 3, 2020 22:05
- The initialization of the framework and the loading of checks is much better
  logged now. The test loading and filtering is logged at the verbose level.
- A new debug level, DEBUG2, was introduced. All messages from the execution
  policies and the actual OS commands that are being executed are logged in this
  level.
- The default level for the logger objects is now set to "undefined." This
  allows for the seamless addition of new debug levels in the future.
@vkarak vkarak added this to the ReFrame sprint 20.16 milestone Nov 3, 2020
@vkarak vkarak requested review from teojgo and victorusu November 3, 2020 21:41
@vkarak vkarak self-assigned this Nov 3, 2020
@vkarak vkarak changed the title [feat] Add more verbose and debug calls [feat] Better logging of framework activities, especially test loading Nov 3, 2020
@codecov-io
Copy link

codecov-io commented Nov 3, 2020

Codecov Report

Merging #1571 into master will decrease coverage by 0.04%.
The diff coverage is 85.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1571      +/-   ##
==========================================
- Coverage   88.04%   87.99%   -0.05%     
==========================================
  Files          44       44              
  Lines        6899     6958      +59     
==========================================
+ Hits         6074     6123      +49     
- Misses        825      835      +10     
Impacted Files Coverage Δ
reframe/core/schedulers/pbs.py 64.70% <ø> (+0.28%) ⬆️
reframe/core/schedulers/torque.py 19.40% <0.00%> (-1.19%) ⬇️
reframe/core/settings.py 100.00% <ø> (ø)
reframe/core/schedulers/slurm.py 53.61% <38.46%> (-0.43%) ⬇️
reframe/core/logging.py 83.38% <80.00%> (-0.06%) ⬇️
reframe/frontend/cli.py 79.53% <83.87%> (+0.71%) ⬆️
reframe/core/config.py 90.57% <87.50%> (-0.29%) ⬇️
reframe/frontend/loader.py 91.17% <88.88%> (-0.23%) ⬇️
reframe/core/pipeline.py 92.00% <90.00%> (-0.45%) ⬇️
reframe/core/exceptions.py 93.43% <100.00%> (+0.19%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36e9635...e863ded. Read the comment docs.

@vkarak vkarak requested a review from ekouts November 4, 2020 08:28
Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@vkarak
Copy link
Contributor Author

vkarak commented Nov 4, 2020

@jenkins-cscs retry daint

@vkarak vkarak merged commit 07e6758 into reframe-hpc:master Nov 4, 2020
@vkarak vkarak deleted the feat/improve-debug-calls branch November 4, 2020 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve debug information that is being logged

3 participants