[bugfix] Fix unit test error due the PID 1 problem when running inside a Docker container #1583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarak
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1583 +/- ##
=======================================
Coverage 87.99% 87.99%
=======================================
Files 45 45
Lines 7016 7016
=======================================
Hits 6174 6174
Misses 842 842 Continue to review full report at Codecov.
|
Contributor
|
Funny thing though. The fact that the unit tests fail but the framework doesn't! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
assert_process_died()function was failing for the local scheduler when the unit tests were run inside a container. The reason for that is that the Python process was run with pid=1, thus inheriting the children that were killed in some of the unit tests. Since these children were never waited for, the remained zombies, thus having still a valid PID.