[feat] Validate tests after loading them #1599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 13, 2020 16:12
- Tests must provide `valid_systems` and `valid_prog_environs` - Tests must not use generator objects or file objects inside their constructors.
|
Hello @vkarak, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2020-11-16 15:14:45 UTC |
added 2 commits
November 13, 2020 23:55
Codecov Report
@@ Coverage Diff @@
## master #1599 +/- ##
==========================================
+ Coverage 87.48% 87.57% +0.09%
==========================================
Files 45 45
Lines 7127 7244 +117
==========================================
+ Hits 6235 6344 +109
- Misses 892 900 +8
Continue to review full report at Codecov.
|
ekouts
approved these changes
Nov 16, 2020
added 4 commits
November 16, 2020 15:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a post-init validation step to the check loader. A test must fulfil the following requirements in order to be loaded:
valid_systems.valid_prog_environs.Implementing (3) without copying the object was quite tricky. I had to implement a validator that recursively descends into the object and checks that every attribute fulfils a condition. The validator examines also any built-in container types element-by-element. The second tricky part was to implement the
is_copyable()condition, i.e., understanding that an object can be copied without doing the actual copy. For this, I had to sneak in thecopy.deepcopy()'s implementation, because, essentially, we want to returnTrueiff the object can be deep-copied.The validation step does not check whether
sanity_patternsis set, because this can be set in a pipeline hook.Fixes #701.
Fixes #795.
Fixes #55.