[bugfix] Treat conflicts in module mappings properly #1611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarak
force-pushed
the
bugfix/treat-conflicts-module-mappings
branch
from
79d3956 to
576ba91
Compare
- The scenario is invalid for this modules system.
teojgo
requested changes
Nov 23, 2020
Contributor
teojgo
left a comment
teojgo
left a comment
There was a problem hiding this comment.
Maybe also change the documentation for emit_load_commands and emit_unload_commands
Contributor
Author
You mean the fact that they do not take into account anymore the module mapping? |
Contributor
No, I mean you should use plural here since you get a list of commands: |
teojgo
requested changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When modules are mapped with the
-Moption and there are conflicts in the replacement sequence of modules, emit the the module load and unload commands in the correct order.Fixes #1274.