Skip to content

[feat] Remove deprecated pre_run, post_run, prebuild_cmd and postbuild_cmd attributes #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2020
Merged

[feat] Remove deprecated pre_run, post_run, prebuild_cmd and postbuild_cmd attributes #1625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4ab4c5
Remove deprecated fields
Nov 29, 2020
095e13e
Remove unused import and update migration guide
Nov 29, 2020
ad37ce0
Merge branch 'master' into feat/remove-depreated-attributes
Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/migration_2_to_3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,9 @@ Other deprecations
The :attr:`prebuild_cmd` and :attr:`postbuild_cmd` test attributes are replaced by the :attr:`prebuild_cmds` and :attr:`postbuild_cmds` respectively.
Similarly, the :attr:`pre_run` and :attr:`post_run` test attributes are replaced by the :attr:`prerun_cmds` and :attr:`postrun_cmds` respectively.

.. warning::
.. versionchanged:: 3.4
The :attr:`prebuild_cmd`, :attr:`postbuild_cmd`, :attr:`pre_run` and :attr:`post_run` attributes have been removed.


Suppressing deprecation warnings
Expand Down
34 changes: 1 addition & 33 deletions reframe/core/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
import reframe.utility.udeps as udeps
from reframe.core.backends import (getlauncher, getscheduler)
from reframe.core.buildsystems import BuildSystemField
from reframe.core.containers import ContainerPlatform, ContainerPlatformField
from reframe.core.containers import ContainerPlatformField
from reframe.core.deferrable import _DeferredExpression
from reframe.core.exceptions import (BuildError, DependencyError,
PipelineError, SanityError,
Expand Down Expand Up @@ -275,14 +275,6 @@ def pipeline_hooks(cls):
#: :default: ``[]``
prebuild_cmds = fields.TypedField('prebuild_cmds', typ.List[str])

#: .. deprecated:: 3.0
#:
#: Use :attr:`prebuild_cmds` instead.
prebuild_cmd = fields.DeprecatedField(
fields.TypedField('prebuild_cmds', typ.List[str]),
"'prebuild_cmd' is deprecated; please use 'prebuild_cmds' instead"
)

#: .. versionadded:: 3.0
#:
#: List of shell commands to be executed after a successful compilation.
Expand All @@ -295,14 +287,6 @@ def pipeline_hooks(cls):
#: :default: ``[]``
postbuild_cmds = fields.TypedField('postbuild_cmds', typ.List[str])

#: .. deprecated:: 3.0
#:
#: Use :attr:`postbuild_cmds` instead.
postbuild_cmd = fields.DeprecatedField(
fields.TypedField('postbuild_cmds', typ.List[str]),
"'postbuild_cmd' is deprecated; please use 'postbuild_cmds' instead"
)

#: The name of the executable to be launched during the run phase.
#:
#: :type: :class:`str`
Expand Down Expand Up @@ -352,14 +336,6 @@ def pipeline_hooks(cls):
#: :default: ``[]``
prerun_cmds = fields.TypedField('prerun_cmds', typ.List[str])

#: .. deprecated:: 3.0
#:
#: Use :attr:`prerun_cmds` instead.
pre_run = fields.DeprecatedField(
fields.TypedField('prerun_cmds', typ.List[str]),
"'pre_run' is deprecated; please use 'prerun_cmds' instead"
)

#: .. versionadded:: 3.0
#:
#: List of shell commands to execute after launching this job.
Expand All @@ -371,14 +347,6 @@ def pipeline_hooks(cls):
#: :default: ``[]``
postrun_cmds = fields.TypedField('postrun_cmds', typ.List[str])

#: .. deprecated:: 3.0
#:
#: Use :attr:`postrun_cmds` instead.
post_run = fields.DeprecatedField(
fields.TypedField('postrun_cmds', typ.List[str]),
"'post_run' is deprecated; please use 'postrun_cmds' instead"
)

#: List of files to be kept after the test finishes.
#:
#: By default, the framework saves the standard output, the standard error
Expand Down