-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Add new action for generating dynamic Gitlab pipelines #1641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add new action for generating dynamic Gitlab pipelines #1641
Conversation
|
Hello @victorusu, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2021-02-08 19:29:47 UTC |
|
This PR suffers from the testcase vs test dependency syndrome. 😬 |
Codecov Report
@@ Coverage Diff @@
## master #1641 +/- ##
==========================================
- Coverage 87.27% 86.99% -0.28%
==========================================
Files 46 47 +1
Lines 7708 7751 +43
==========================================
+ Hits 6727 6743 +16
- Misses 981 1008 +27
Continue to review full report at Codecov.
|
c37a1db to
fcf0023
Compare
victorusu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the feature and it is working perfectly!
I liked the additional lint using the GitLab API.
I just have one comment about one sentence that has them too much. That's minor. IMHO, it could also go that way.
This is an initial draft of
--ci-generatefeature.The feature allows for creating GitLab dynamic pipelines.
missing:
dependencies.topsortto use the_dfsfunctionExample Gitlab pipeline running the corrected
deps_complex.pyexample: https://gitlab.com/cscs-ci/ues/reframe-ci-generate/-/pipelines/251101610Other:
Fixes #1523.