Skip to content

Conversation

@victorusu
Copy link
Contributor

@victorusu victorusu commented Dec 3, 2020

This is an initial draft of --ci-generate feature.
The feature allows for creating GitLab dynamic pipelines.

missing:

  • fix overall variable names
  • fix dependencies.topsort to use the _dfs function
  • perform several small issues
  • test in real life Gitlab CI pipelines
  • add unitests, unittests and unittests!
  • add documentation

Example Gitlab pipeline running the corrected deps_complex.py example: https://gitlab.com/cscs-ci/ues/reframe-ci-generate/-/pipelines/251101610

Other:

  • ReFrame must be installed in the runner.

Fixes #1523.

@victorusu victorusu added this to the ReFrame sprint 20.18 milestone Dec 3, 2020
@victorusu victorusu requested a review from vkarak December 3, 2020 21:23
@victorusu victorusu self-assigned this Dec 3, 2020
@victorusu victorusu marked this pull request as draft December 3, 2020 21:23
@pep8speaks
Copy link

pep8speaks commented Dec 3, 2020

Hello @victorusu, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2021-02-08 19:29:47 UTC

@victorusu victorusu changed the title Ci generate pipeline new [feat] Add support to generate dynamic Gitlab pipelines Dec 3, 2020
@victorusu
Copy link
Contributor Author

This PR suffers from the testcase vs test dependency syndrome. 😬
Check this gist.

@codecov-io
Copy link

codecov-io commented Feb 2, 2021

Codecov Report

Merging #1641 (fcf0023) into master (8dca540) will decrease coverage by 0.27%.
The diff coverage is 41.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1641      +/-   ##
==========================================
- Coverage   87.27%   86.99%   -0.28%     
==========================================
  Files          46       47       +1     
  Lines        7708     7751      +43     
==========================================
+ Hits         6727     6743      +16     
- Misses        981     1008      +27     
Impacted Files Coverage Δ
reframe/frontend/ci.py 20.00% <20.00%> (ø)
reframe/frontend/cli.py 76.45% <50.00%> (-0.34%) ⬇️
reframe/frontend/dependencies.py 96.64% <100.00%> (+0.14%) ⬆️
reframe/frontend/executors/__init__.py 98.19% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dca540...fcf0023. Read the comment docs.

@vkarak vkarak force-pushed the ci-generate-pipeline-new branch from c37a1db to fcf0023 Compare February 3, 2021 22:46
@vkarak vkarak requested a review from teojgo February 4, 2021 22:01
@vkarak vkarak marked this pull request as ready for review February 5, 2021 22:38
Copy link
Contributor Author

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the feature and it is working perfectly!
I liked the additional lint using the GitLab API.
I just have one comment about one sentence that has them too much. That's minor. IMHO, it could also go that way.

@vkarak vkarak changed the title [feat] Add support to generate dynamic Gitlab pipelines [feat] Add new action for generating dynamic Gitlab pipelines Feb 8, 2021
@vkarak vkarak merged commit 78242ff into reframe-hpc:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create dynamic Gitlab pipelines from ReFrame tests

4 participants