Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Dec 14, 2020

No description provided.

@teojgo teojgo added this to the ReFrame sprint 20.19 milestone Dec 14, 2020
@teojgo teojgo requested a review from vkarak December 14, 2020 12:21
@teojgo teojgo self-assigned this Dec 14, 2020
@codecov-io
Copy link

codecov-io commented Dec 14, 2020

Codecov Report

Merging #1655 (2e8a8f4) into master (4b35b02) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1655   +/-   ##
=======================================
  Coverage   87.55%   87.55%           
=======================================
  Files          45       45           
  Lines        7494     7494           
=======================================
  Hits         6561     6561           
  Misses        933      933           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b35b02...2e8a8f4. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minor comment, which I can fix.

@vkarak vkarak changed the title [bugfix] Ensure that module paths are restored in tests [ci] Ensure that module paths are restored correctly in unit tests Dec 15, 2020
@vkarak vkarak merged commit 0227b31 into reframe-hpc:master Dec 15, 2020
@teojgo teojgo deleted the bugfix/unittest_module_cleanup branch April 2, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants