[bugfix] Properly expand environment variables for the filelog log handler #1659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1659 +/- ##
=======================================
Coverage 87.65% 87.65%
=======================================
Files 45 45
Lines 7485 7485
=======================================
Hits 6561 6561
Misses 924 924
Continue to review full report at Codecov.
|
ekouts
approved these changes
Dec 15, 2020
teojgo
approved these changes
Dec 15, 2020
Contributor
teojgo
left a comment
teojgo
left a comment
There was a problem hiding this comment.
lgtm I have tested and it works fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1638.