Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Dec 17, 2020

Fixes #1632

@teojgo teojgo added this to the ReFrame sprint 20.19 milestone Dec 17, 2020
@teojgo teojgo requested review from victorusu and vkarak December 17, 2020 12:57
@teojgo teojgo self-assigned this Dec 17, 2020
@pep8speaks
Copy link

pep8speaks commented Dec 17, 2020

Hello @teojgo, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2020-12-17 13:10:09 UTC

@codecov-io
Copy link

codecov-io commented Dec 17, 2020

Codecov Report

Merging #1662 (ffcc5cc) into master (8134945) will decrease coverage by 0.00%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1662      +/-   ##
==========================================
- Coverage   87.55%   87.54%   -0.01%     
==========================================
  Files          45       45              
  Lines        7494     7492       -2     
==========================================
- Hits         6561     6559       -2     
  Misses        933      933              
Impacted Files Coverage Δ
reframe/core/schedulers/slurm.py 53.78% <0.00%> (-0.13%) ⬇️
reframe/core/schedulers/pbs.py 47.58% <50.00%> (-0.36%) ⬇️
reframe/core/schedulers/__init__.py 97.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8134945...ffcc5cc. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [bugfix] Pass the jobid when raising a 'JobError' [bugfix] Pass the job id when raising job-related errors Dec 17, 2020
@vkarak
Copy link
Contributor

vkarak commented Dec 17, 2020

@jenkins-cscs retry daint

@vkarak vkarak merged commit 01d7efc into reframe-hpc:master Dec 17, 2020
@teojgo teojgo deleted the bugfix/joberror_jobid branch April 2, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revisit how JobError is constructed and raised

4 participants