From f6713be93cc9d1916dcfa8fae3cf65a1cb451e0a Mon Sep 17 00:00:00 2001 From: Eirini Koutsaniti Date: Thu, 7 Jan 2021 10:50:40 +0100 Subject: [PATCH 1/2] Fix unnecessary marking of failed tasks for ABORT_REASONS When reframe catches the following errors (KeyboardInterrupt, ReframeForceExitError, AssertionError) it unnecessarily marks as failures tasks from retired and completed tasks. This leads to confusing output. --- reframe/frontend/executors/policies.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/reframe/frontend/executors/policies.py b/reframe/frontend/executors/policies.py index 5dab71103f..e85465d922 100644 --- a/reframe/frontend/executors/policies.py +++ b/reframe/frontend/executors/policies.py @@ -439,9 +439,7 @@ def _failall(self, cause): for task in ready_list: task.abort(cause) - for task in itertools.chain(self._waiting_tasks, - self._retired_tasks, - self._completed_tasks): + for task in self._waiting_tasks: task.abort(cause) def _reschedule(self, task): From 83ac4d9c2049b38ae8e098a476c34ac16534f04e Mon Sep 17 00:00:00 2001 From: Eirini Koutsaniti Date: Thu, 7 Jan 2021 11:18:05 +0100 Subject: [PATCH 2/2] Add back completed tasks --- reframe/frontend/executors/policies.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/reframe/frontend/executors/policies.py b/reframe/frontend/executors/policies.py index e85465d922..827aa44003 100644 --- a/reframe/frontend/executors/policies.py +++ b/reframe/frontend/executors/policies.py @@ -439,7 +439,8 @@ def _failall(self, cause): for task in ready_list: task.abort(cause) - for task in self._waiting_tasks: + for task in itertools.chain(self._waiting_tasks, + self._completed_tasks): task.abort(cause) def _reschedule(self, task):