Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Feb 8, 2021

I adapted the .. versionadded:: annotation to the correct version.

@vkarak vkarak added this to the ReFrame 3.4.1 milestone Feb 8, 2021
@vkarak vkarak requested a review from teojgo February 8, 2021 15:14
@vkarak vkarak self-assigned this Feb 8, 2021
@vkarak vkarak requested a review from victorusu February 8, 2021 15:28
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-io
Copy link

Codecov Report

Merging #1754 (eebff5a) into master (d173849) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1754   +/-   ##
=======================================
  Coverage   87.34%   87.34%           
=======================================
  Files          46       46           
  Lines        7742     7742           
=======================================
  Hits         6762     6762           
  Misses        980      980           
Impacted Files Coverage Δ
reframe/utility/sanity.py 97.77% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d173849...eebff5a. Read the comment docs.

@vkarak vkarak merged commit 9fb3397 into reframe-hpc:master Feb 8, 2021
@vkarak vkarak deleted the docs/fix-versionadded-sanity-fn branch February 8, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants