From d8606ffdddef6b5bf10221f985dc7b6c49092d70 Mon Sep 17 00:00:00 2001 From: Theofilos Manitaras Date: Tue, 16 Feb 2021 12:02:46 +0100 Subject: [PATCH 1/9] Adapt environ regression tests to eiger --- cscs-checks/prgenv/environ_check.py | 67 ++++++++++++++++++++++++++--- 1 file changed, 61 insertions(+), 6 deletions(-) diff --git a/cscs-checks/prgenv/environ_check.py b/cscs-checks/prgenv/environ_check.py index 5777ceb16c..7566d21c9a 100644 --- a/cscs-checks/prgenv/environ_check.py +++ b/cscs-checks/prgenv/environ_check.py @@ -13,22 +13,28 @@ class DefaultPrgEnvCheck(rfm.RunOnlyRegressionTest): def __init__(self): self.descr = 'Ensure PrgEnv-cray is loaded by default' self.valid_prog_environs = ['builtin'] - self.valid_systems = ['daint:login', 'dom:login'] + self.valid_systems = ['daint:login', 'dom:login', 'eiger:login'] self.executable = 'module' self.executable_opts = ['list', '-t'] self.maintainers = ['TM', 'CB'] self.tags = {'production', 'craype'} self.sanity_patterns = sn.assert_found(r'^PrgEnv-cray', self.stderr) + @rfm.run_before('setup') + def setup_eiger(self): + if self.current_system.name == 'eiger': + self.executable_opts = ['list'] + self.sanity_patterns = sn.assert_found(r'1\) cpe-cray', + self.stderr) + @rfm.simple_test class EnvironmentCheck(rfm.RunOnlyRegressionTest): def __init__(self): self.descr = 'Ensure programming environment is loaded correctly' - self.valid_systems = ['daint:login', 'dom:login'] - self.valid_prog_environs = ['PrgEnv-cray', 'PrgEnv-gnu', - 'PrgEnv-intel', 'PrgEnv-pgi'] - + self.valid_systems = ['daint:login', 'dom:login', 'eiger:login'] + self.valid_prog_environs = ['PrgEnv-cray', 'PrgEnv-gnu', 'PrgEnv-pgi', + 'PrgEnv-intel', 'PrgEnv-aocc'] self.executable = 'module' self.executable_opts = ['list', '-t'] self.sanity_patterns = sn.assert_found(self.env_module_patt, @@ -36,10 +42,21 @@ def __init__(self): self.maintainers = ['TM', 'CB'] self.tags = {'production', 'craype'} + @rfm.run_before('setup') + def setup_eiger(self): + if self.current_system.name == 'eiger': + self.executable_opts = ['list'] + @property @sn.sanity_function def env_module_patt(self): - return r'^%s' % self.current_environ.name + # NOTE: On eiger, the first module of each programming environment, + # follows the 'cpe-' pattern where corresponds to the + # 'PrgEnv-' used. + if self.current_system.name == 'eiger': + return rf'1\) cpe-{self.current_environ.name[7:]}' + + return rf'^{self.current_environ.name}' @rfm.parameterized_test(['cray-fftw'], ['cray-hdf5'], ['cray-hdf5-parallel'], @@ -75,3 +92,41 @@ def __init__(self, module_name): self.maintainers = ['EK', 'VH'] self.tags = {'production', 'craype'} + + +@rfm.parameterized_test(['cray-ccdb'], ['cray-cti'], ['cray-dsmml'], + ['cray-fftw'], ['cray-hdf5'], ['cray-hdf5-parallel'], + ['cray-libsci'], ['cray-openshmemx'], + ['cray-parallel-netcdf'], ['cray-pmi'], + ['cray-python'], ['cray-R'], ['gcc'], ['papi']) +class CrayVariablesCheckEiger(rfm.RunOnlyRegressionTest): + def __init__(self, module_name): + self.descr = 'Check for standard Cray variables on Eiger' + self.valid_systems = ['eiger:login'] + self.valid_prog_environs = ['builtin'] + self.executable = 'module' + self.executable_opts = ['show', module_name] + envvar_prefix = module_name.upper().replace('-', '_') + + # NOTE: In some modules the 'CRAY_' prefix is not used in the + # environment variable names. + if envvar_prefix.startswith('CRAY_'): + envvar_prefix_nocray = envvar_prefix[5:] + prefix_pattern = f'{envvar_prefix}_|{envvar_prefix_nocray}_' + else: + prefix_pattern = f'{envvar_prefix}_' + + self.sanity_patterns = sn.all([ + sn.assert_found(rf'({prefix_pattern})?(PREFIX|INSTALL)(_DIR)?', + self.stderr), + sn.assert_found(rf'({prefix_pattern})(VERSION|LEVEL)', self.stderr) + ]) + + if module_name == 'cray-fftw': + self.sanity_patterns = sn.all([ + sn.assert_found(f'FFTW_DIR', self.stderr), + sn.assert_found(f'{envvar_prefix}_VERSION', self.stderr) + ]) + + self.maintainers = ['TM'] + self.tags = {'production', 'craype'} From c64f3feab2c76b9b16e62db5bb88a346e1a869f5 Mon Sep 17 00:00:00 2001 From: Theofilos Manitaras Date: Wed, 17 Feb 2021 09:29:41 +0100 Subject: [PATCH 2/9] Remove checks for modules to be fixed in later releases --- cscs-checks/prgenv/environ_check.py | 26 +++++++------------------- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/cscs-checks/prgenv/environ_check.py b/cscs-checks/prgenv/environ_check.py index 7566d21c9a..72bc505f3b 100644 --- a/cscs-checks/prgenv/environ_check.py +++ b/cscs-checks/prgenv/environ_check.py @@ -94,8 +94,7 @@ def __init__(self, module_name): self.tags = {'production', 'craype'} -@rfm.parameterized_test(['cray-ccdb'], ['cray-cti'], ['cray-dsmml'], - ['cray-fftw'], ['cray-hdf5'], ['cray-hdf5-parallel'], +@rfm.parameterized_test(['cray-fftw'], ['cray-hdf5'], ['cray-hdf5-parallel'], ['cray-libsci'], ['cray-openshmemx'], ['cray-parallel-netcdf'], ['cray-pmi'], ['cray-python'], ['cray-R'], ['gcc'], ['papi']) @@ -107,26 +106,15 @@ def __init__(self, module_name): self.executable = 'module' self.executable_opts = ['show', module_name] envvar_prefix = module_name.upper().replace('-', '_') - - # NOTE: In some modules the 'CRAY_' prefix is not used in the - # environment variable names. - if envvar_prefix.startswith('CRAY_'): - envvar_prefix_nocray = envvar_prefix[5:] - prefix_pattern = f'{envvar_prefix}_|{envvar_prefix_nocray}_' - else: - prefix_pattern = f'{envvar_prefix}_' - self.sanity_patterns = sn.all([ - sn.assert_found(rf'({prefix_pattern})?(PREFIX|INSTALL)(_DIR)?', - self.stderr), - sn.assert_found(rf'({prefix_pattern})(VERSION|LEVEL)', self.stderr) + sn.assert_found(f'{envvar_prefix}_PREFIX', self.stderr), + sn.assert_found(f'{envvar_prefix}_VERSION', self.stderr) ]) - if module_name == 'cray-fftw': - self.sanity_patterns = sn.all([ - sn.assert_found(f'FFTW_DIR', self.stderr), - sn.assert_found(f'{envvar_prefix}_VERSION', self.stderr) - ]) + # FIXME: These modules should be fixed in later releases + + if module_name in {'cray-fftw', 'cray-python'}: + self.valid_systems = [] self.maintainers = ['TM'] self.tags = {'production', 'craype'} From 330d32ab32156ef16864ca61b96375c374e1ecda Mon Sep 17 00:00:00 2001 From: Theofilos Manitaras Date: Wed, 17 Feb 2021 14:49:59 +0100 Subject: [PATCH 3/9] Create Mixin class for common functionality --- cscs-checks/prgenv/environ_check.py | 42 +++++++++++++---------------- 1 file changed, 19 insertions(+), 23 deletions(-) diff --git a/cscs-checks/prgenv/environ_check.py b/cscs-checks/prgenv/environ_check.py index 72bc505f3b..d448c68280 100644 --- a/cscs-checks/prgenv/environ_check.py +++ b/cscs-checks/prgenv/environ_check.py @@ -59,17 +59,9 @@ def env_module_patt(self): return rf'^{self.current_environ.name}' -@rfm.parameterized_test(['cray-fftw'], ['cray-hdf5'], ['cray-hdf5-parallel'], - ['cray-libsci'], ['cray-netcdf'], - ['cray-netcdf-hdf5parallel'], ['cray-petsc'], - ['cray-petsc-64'], ['cray-petsc-complex'], - ['cray-petsc-complex-64'], ['cray-python'], - ['cray-R'], ['cray-tpsl'], ['cray-tpsl-64'], - ['cudatoolkit'], ['gcc'], ['papi'], ['pmi']) -class CrayVariablesCheck(rfm.RunOnlyRegressionTest): +class CrayVariablesCheckMixin: def __init__(self, module_name): self.descr = 'Check for standard Cray variables' - self.valid_systems = ['daint:login', 'dom:login'] self.valid_prog_environs = ['builtin'] self.executable = 'module' self.executable_opts = ['show', module_name] @@ -78,6 +70,19 @@ def __init__(self, module_name): sn.assert_found(f'{envvar_prefix}_PREFIX', self.stderr), sn.assert_found(f'{envvar_prefix}_VERSION', self.stderr) ]) + self.tags = {'production', 'craype'} + + +@rfm.parameterized_test(['cray-fftw'], ['cray-hdf5'], ['cray-hdf5-parallel'], + ['cray-libsci'], ['cray-mpich'], ['cray-netcdf'], + ['cray-netcdf-hdf5parallel'], ['cray-petsc'], + ['cray-petsc-complex-64'], ['cray-python'], + ['cray-R'], ['cray-tpsl'], ['cray-tpsl-64'], + ['cudatoolkit'], ['gcc'], ['papi'], ['pmi']) +class CrayVariablesCheck(rfm.RunOnlyRegressionTest, CrayVariablesCheckMixin): + def __init__(self, module_name): + CrayVariablesCheckMixin.__init__(self, module_name) + self.valid_systems = ['daint:login', 'dom:login'] # FIXME: These modules should be fixed in later releases, # while gcc was fixed in 20.11 @@ -91,30 +96,21 @@ def __init__(self, module_name): self.valid_systems = [] self.maintainers = ['EK', 'VH'] - self.tags = {'production', 'craype'} @rfm.parameterized_test(['cray-fftw'], ['cray-hdf5'], ['cray-hdf5-parallel'], - ['cray-libsci'], ['cray-openshmemx'], + ['cray-libsci'], ['cray-mpich'], ['cray-openshmemx'], ['cray-parallel-netcdf'], ['cray-pmi'], ['cray-python'], ['cray-R'], ['gcc'], ['papi']) -class CrayVariablesCheckEiger(rfm.RunOnlyRegressionTest): +class CrayVariablesCheckEiger(rfm.RunOnlyRegressionTest, + CrayVariablesCheckMixin): def __init__(self, module_name): - self.descr = 'Check for standard Cray variables on Eiger' + CrayVariablesCheckMixin.__init__(self, module_name) self.valid_systems = ['eiger:login'] - self.valid_prog_environs = ['builtin'] - self.executable = 'module' - self.executable_opts = ['show', module_name] - envvar_prefix = module_name.upper().replace('-', '_') - self.sanity_patterns = sn.all([ - sn.assert_found(f'{envvar_prefix}_PREFIX', self.stderr), - sn.assert_found(f'{envvar_prefix}_VERSION', self.stderr) - ]) # FIXME: These modules should be fixed in later releases - if module_name in {'cray-fftw', 'cray-python'}: + if module_name in {'cray-fftw', 'cray-python', 'cray-mpich'}: self.valid_systems = [] self.maintainers = ['TM'] - self.tags = {'production', 'craype'} From dec484beee8e2a820e54ae09ca3ab679c47b45aa Mon Sep 17 00:00:00 2001 From: Vasileios Karakasis Date: Wed, 17 Feb 2021 21:23:11 +0100 Subject: [PATCH 4/9] Style improvements --- cscs-checks/prgenv/environ_check.py | 35 ++++++++++++++--------------- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/cscs-checks/prgenv/environ_check.py b/cscs-checks/prgenv/environ_check.py index d448c68280..d6572ff0b6 100644 --- a/cscs-checks/prgenv/environ_check.py +++ b/cscs-checks/prgenv/environ_check.py @@ -15,17 +15,18 @@ def __init__(self): self.valid_prog_environs = ['builtin'] self.valid_systems = ['daint:login', 'dom:login', 'eiger:login'] self.executable = 'module' - self.executable_opts = ['list', '-t'] self.maintainers = ['TM', 'CB'] self.tags = {'production', 'craype'} self.sanity_patterns = sn.assert_found(r'^PrgEnv-cray', self.stderr) - @rfm.run_before('setup') - def setup_eiger(self): if self.current_system.name == 'eiger': self.executable_opts = ['list'] - self.sanity_patterns = sn.assert_found(r'1\) cpe-cray', - self.stderr) + prgenv_patt = r'1\) cpe-cray' + else: + self.executable_opts = ['list', '-t'] + prgenv_patt = r'^PrgEnv-cray' + + self.sanity_patterns = sn.assert_found(prgenv_patt, self.stderr) @rfm.simple_test @@ -36,27 +37,25 @@ def __init__(self): self.valid_prog_environs = ['PrgEnv-cray', 'PrgEnv-gnu', 'PrgEnv-pgi', 'PrgEnv-intel', 'PrgEnv-aocc'] self.executable = 'module' - self.executable_opts = ['list', '-t'] - self.sanity_patterns = sn.assert_found(self.env_module_patt, - self.stderr) - self.maintainers = ['TM', 'CB'] - self.tags = {'production', 'craype'} - - @rfm.run_before('setup') - def setup_eiger(self): if self.current_system.name == 'eiger': self.executable_opts = ['list'] + else: + self.executable_opts = ['list', '-t'] + + self.maintainers = ['TM', 'CB'] + self.tags = {'production', 'craype'} - @property - @sn.sanity_function - def env_module_patt(self): + @rfm.run_before('sanity') + def set_sanity(self): # NOTE: On eiger, the first module of each programming environment, # follows the 'cpe-' pattern where corresponds to the # 'PrgEnv-' used. if self.current_system.name == 'eiger': - return rf'1\) cpe-{self.current_environ.name[7:]}' + module_patt = rf'1\) cpe-{self.current_environ.name[7:]}' + else: + module_patt = rf'^{self.current_environ.name}' - return rf'^{self.current_environ.name}' + self.sanity_patterns = sn.assert_found(module_patt, self.stderr) class CrayVariablesCheckMixin: From 677b8344b175487510b5593fad0c55e3b590f66e Mon Sep 17 00:00:00 2001 From: Theofilos Manitaras Date: Thu, 18 Feb 2021 17:47:41 +0100 Subject: [PATCH 5/9] Use the parameter built-in --- cscs-checks/prgenv/environ_check.py | 54 ++++++++++++++++------------- 1 file changed, 29 insertions(+), 25 deletions(-) diff --git a/cscs-checks/prgenv/environ_check.py b/cscs-checks/prgenv/environ_check.py index d6572ff0b6..5c14886884 100644 --- a/cscs-checks/prgenv/environ_check.py +++ b/cscs-checks/prgenv/environ_check.py @@ -58,13 +58,13 @@ def set_sanity(self): self.sanity_patterns = sn.assert_found(module_patt, self.stderr) -class CrayVariablesCheckMixin: - def __init__(self, module_name): +class CrayVariablesCheckBase(rfm.RunOnlyRegressionTest): + def __init__(self): self.descr = 'Check for standard Cray variables' self.valid_prog_environs = ['builtin'] self.executable = 'module' - self.executable_opts = ['show', module_name] - envvar_prefix = module_name.upper().replace('-', '_') + self.executable_opts = ['show', self.cray_module] + envvar_prefix = self.cray_module.upper().replace('-', '_') self.sanity_patterns = sn.all([ sn.assert_found(f'{envvar_prefix}_PREFIX', self.stderr), sn.assert_found(f'{envvar_prefix}_VERSION', self.stderr) @@ -72,15 +72,17 @@ def __init__(self, module_name): self.tags = {'production', 'craype'} -@rfm.parameterized_test(['cray-fftw'], ['cray-hdf5'], ['cray-hdf5-parallel'], - ['cray-libsci'], ['cray-mpich'], ['cray-netcdf'], - ['cray-netcdf-hdf5parallel'], ['cray-petsc'], - ['cray-petsc-complex-64'], ['cray-python'], - ['cray-R'], ['cray-tpsl'], ['cray-tpsl-64'], - ['cudatoolkit'], ['gcc'], ['papi'], ['pmi']) -class CrayVariablesCheck(rfm.RunOnlyRegressionTest, CrayVariablesCheckMixin): - def __init__(self, module_name): - CrayVariablesCheckMixin.__init__(self, module_name) +@rfm.simple_test +class CrayVariablesCheck(CrayVariablesCheckBase): + cray_module = parameter([ + 'cray-fftw', 'cray-hdf5', 'cray-hdf5-parallel', 'cray-libsci', + 'cray-mpich', 'cray-netcdf', 'cray-netcdf-hdf5parallel', 'cray-petsc', + 'cray-petsc-complex-64', 'cray-python', 'cray-R', 'cray-tpsl', + 'cray-tpsl-64', 'cudatoolkit', 'gcc', 'papi', 'pmi' + ]) + + def __init__(self): + super().__init__() self.valid_systems = ['daint:login', 'dom:login'] # FIXME: These modules should be fixed in later releases, @@ -88,28 +90,30 @@ def __init__(self, module_name): cdt = osext.cray_cdt_version() if ((cdt and cdt <= '20.11' and - module_name in ['cray-petsc-complex', - 'cray-petsc-complex-64', - 'cudatoolkit']) or + self.cray_module in ['cray-petsc-complex', + 'cray-petsc-complex-64', + 'cudatoolkit']) or (cdt and cdt < '20.11' and module_name == 'gcc')): self.valid_systems = [] self.maintainers = ['EK', 'VH'] -@rfm.parameterized_test(['cray-fftw'], ['cray-hdf5'], ['cray-hdf5-parallel'], - ['cray-libsci'], ['cray-mpich'], ['cray-openshmemx'], - ['cray-parallel-netcdf'], ['cray-pmi'], - ['cray-python'], ['cray-R'], ['gcc'], ['papi']) -class CrayVariablesCheckEiger(rfm.RunOnlyRegressionTest, - CrayVariablesCheckMixin): - def __init__(self, module_name): - CrayVariablesCheckMixin.__init__(self, module_name) +@rfm.simple_test +class CrayVariablesCheckEiger(CrayVariablesCheckBase): + cray_module = parameter([ + 'cray-fftw', 'cray-hdf5', 'cray-hdf5-parallel', 'cray-libsci', + 'cray-mpich', 'cray-openshmemx', 'cray-parallel-netcdf', 'cray-pmi', + 'cray-python', 'cray-R', 'gcc', 'papi' + ]) + + def __init__(self): + super().__init__() self.valid_systems = ['eiger:login'] # FIXME: These modules should be fixed in later releases - if module_name in {'cray-fftw', 'cray-python', 'cray-mpich'}: + if self.cray_module in {'cray-fftw', 'cray-python', 'cray-mpich'}: self.valid_systems = [] self.maintainers = ['TM'] From 59a3955b3219bf2dad35716a307caf8d1b6ce0bb Mon Sep 17 00:00:00 2001 From: Theofilos Manitaras Date: Thu, 18 Feb 2021 17:49:20 +0100 Subject: [PATCH 6/9] PEP8 fixes --- cscs-checks/prgenv/environ_check.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/cscs-checks/prgenv/environ_check.py b/cscs-checks/prgenv/environ_check.py index 5c14886884..38e9677b33 100644 --- a/cscs-checks/prgenv/environ_check.py +++ b/cscs-checks/prgenv/environ_check.py @@ -101,19 +101,19 @@ def __init__(self): @rfm.simple_test class CrayVariablesCheckEiger(CrayVariablesCheckBase): - cray_module = parameter([ + cray_module = parameter([ 'cray-fftw', 'cray-hdf5', 'cray-hdf5-parallel', 'cray-libsci', 'cray-mpich', 'cray-openshmemx', 'cray-parallel-netcdf', 'cray-pmi', 'cray-python', 'cray-R', 'gcc', 'papi' - ]) + ]) - def __init__(self): - super().__init__() - self.valid_systems = ['eiger:login'] + def __init__(self): + super().__init__() + self.valid_systems = ['eiger:login'] - # FIXME: These modules should be fixed in later releases + # FIXME: These modules should be fixed in later releases - if self.cray_module in {'cray-fftw', 'cray-python', 'cray-mpich'}: - self.valid_systems = [] + if self.cray_module in {'cray-fftw', 'cray-python', 'cray-mpich'}: + self.valid_systems = [] - self.maintainers = ['TM'] + self.maintainers = ['TM'] From 0fded343ff152ea16d734e126c413f049ba2b8de Mon Sep 17 00:00:00 2001 From: Theofilos Manitaras Date: Thu, 18 Feb 2021 17:50:11 +0100 Subject: [PATCH 7/9] PEP8 fixes (ver 2) --- cscs-checks/prgenv/environ_check.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/cscs-checks/prgenv/environ_check.py b/cscs-checks/prgenv/environ_check.py index 38e9677b33..337a4ee1b7 100644 --- a/cscs-checks/prgenv/environ_check.py +++ b/cscs-checks/prgenv/environ_check.py @@ -108,12 +108,12 @@ class CrayVariablesCheckEiger(CrayVariablesCheckBase): ]) def __init__(self): - super().__init__() - self.valid_systems = ['eiger:login'] + super().__init__() + self.valid_systems = ['eiger:login'] - # FIXME: These modules should be fixed in later releases + # FIXME: These modules should be fixed in later releases - if self.cray_module in {'cray-fftw', 'cray-python', 'cray-mpich'}: - self.valid_systems = [] + if self.cray_module in {'cray-fftw', 'cray-python', 'cray-mpich'}: + self.valid_systems = [] - self.maintainers = ['TM'] + self.maintainers = ['TM'] From 02920e1c31b0027528c261feb3f072b73b1d0f15 Mon Sep 17 00:00:00 2001 From: Theofilos Manitaras Date: Fri, 19 Feb 2021 10:05:50 +0100 Subject: [PATCH 8/9] Address PR comments --- cscs-checks/prgenv/environ_check.py | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/cscs-checks/prgenv/environ_check.py b/cscs-checks/prgenv/environ_check.py index 337a4ee1b7..24c3d353c3 100644 --- a/cscs-checks/prgenv/environ_check.py +++ b/cscs-checks/prgenv/environ_check.py @@ -58,7 +58,9 @@ def set_sanity(self): self.sanity_patterns = sn.assert_found(module_patt, self.stderr) -class CrayVariablesCheckBase(rfm.RunOnlyRegressionTest): +class CrayVariablesCheck(rfm.RunOnlyRegressionTest): + cray_module = parameter() + def __init__(self): self.descr = 'Check for standard Cray variables' self.valid_prog_environs = ['builtin'] @@ -70,17 +72,17 @@ def __init__(self): sn.assert_found(f'{envvar_prefix}_VERSION', self.stderr) ]) self.tags = {'production', 'craype'} + self.maintainers = ['EK', 'TM'] @rfm.simple_test -class CrayVariablesCheck(CrayVariablesCheckBase): +class CrayVariablesCheckDaint(CrayVariablesCheck): cray_module = parameter([ 'cray-fftw', 'cray-hdf5', 'cray-hdf5-parallel', 'cray-libsci', 'cray-mpich', 'cray-netcdf', 'cray-netcdf-hdf5parallel', 'cray-petsc', 'cray-petsc-complex-64', 'cray-python', 'cray-R', 'cray-tpsl', 'cray-tpsl-64', 'cudatoolkit', 'gcc', 'papi', 'pmi' ]) - def __init__(self): super().__init__() self.valid_systems = ['daint:login', 'dom:login'] @@ -96,11 +98,9 @@ def __init__(self): (cdt and cdt < '20.11' and module_name == 'gcc')): self.valid_systems = [] - self.maintainers = ['EK', 'VH'] - @rfm.simple_test -class CrayVariablesCheckEiger(CrayVariablesCheckBase): +class CrayVariablesCheckEiger(CrayVariablesCheck): cray_module = parameter([ 'cray-fftw', 'cray-hdf5', 'cray-hdf5-parallel', 'cray-libsci', 'cray-mpich', 'cray-openshmemx', 'cray-parallel-netcdf', 'cray-pmi', @@ -115,5 +115,3 @@ def __init__(self): if self.cray_module in {'cray-fftw', 'cray-python', 'cray-mpich'}: self.valid_systems = [] - - self.maintainers = ['TM'] From 167ce21f647f0494756e64c9803eb7c5b6eecfe3 Mon Sep 17 00:00:00 2001 From: Vasileios Karakasis Date: Mon, 22 Feb 2021 10:06:53 +0100 Subject: [PATCH 9/9] Fix PEP8 issue --- cscs-checks/prgenv/environ_check.py | 1 + 1 file changed, 1 insertion(+) diff --git a/cscs-checks/prgenv/environ_check.py b/cscs-checks/prgenv/environ_check.py index 24c3d353c3..ace410b387 100644 --- a/cscs-checks/prgenv/environ_check.py +++ b/cscs-checks/prgenv/environ_check.py @@ -83,6 +83,7 @@ class CrayVariablesCheckDaint(CrayVariablesCheck): 'cray-petsc-complex-64', 'cray-python', 'cray-R', 'cray-tpsl', 'cray-tpsl-64', 'cudatoolkit', 'gcc', 'papi', 'pmi' ]) + def __init__(self): super().__init__() self.valid_systems = ['daint:login', 'dom:login']