Skip to content

Conversation

@lucamar
Copy link
Contributor

@lucamar lucamar commented Feb 19, 2021

I provide the check on Eiger: the pipeline hooks that set the task distribution and cpu binding should improve the performance bit, also on Dom and Piz Daint.

@pep8speaks
Copy link

pep8speaks commented Feb 19, 2021

Hello @lucamar, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2021-02-22 13:23:07 UTC

@codecov-io
Copy link

codecov-io commented Feb 19, 2021

Codecov Report

Merging #1800 (0718dce) into master (44e5f29) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1800   +/-   ##
=======================================
  Coverage   87.57%   87.57%           
=======================================
  Files          49       49           
  Lines        7919     7919           
=======================================
  Hits         6935     6935           
  Misses        984      984           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44e5f29...0718dce. Read the comment docs.

@vkarak vkarak added this to the ReFrame 3.4.2 milestone Feb 22, 2021
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [test] VASP check on Eiger [test] Adapt VASP check for Eiger Feb 22, 2021
@vkarak vkarak merged commit bcd1c7d into reframe-hpc:master Feb 22, 2021
@lucamar lucamar deleted the vasp-eiger branch March 3, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants