Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Feb 26, 2021

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 26, 2021

Codecov Report

Merging #1824 (7297d10) into master (3a39a39) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1824   +/-   ##
=======================================
  Coverage   87.68%   87.68%           
=======================================
  Files          49       49           
  Lines        7979     7979           
=======================================
  Hits         6996     6996           
  Misses        983      983           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a39a39...7297d10. Read the comment docs.

Theofilos Manitaras added 2 commits February 26, 2021 17:03
@teojgo
Copy link
Contributor Author

teojgo commented Mar 1, 2021

@jenkins-cscs retry all

@vkarak vkarak added this to the ReFrame 3.5.0 milestone Mar 1, 2021
@vkarak
Copy link
Contributor

vkarak commented Mar 3, 2021

@teojgo For this one, we need to make sure that the versions in the decorator are correct. I'm not sure that we maintained correctly these version numbers...

@teojgo
Copy link
Contributor Author

teojgo commented Mar 3, 2021

@teojgo For this one, we need to make sure that the versions in the decorator are correct. I'm not sure that we maintained correctly these version numbers...

Ok, I can look at the history to see when each test was introduced.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I think it's better if we remove the annotations completely. We do not actually maintain them. They would make sense if we move the tests in a separate repo.

@teojgo teojgo changed the title [test] Use conformant semantic version in all tests [test] Remove 'required_version' decorator from tests Mar 8, 2021
@vkarak vkarak changed the title [test] Remove 'required_version' decorator from tests [test] Remove @required_version decorator from tests Mar 8, 2021
@vkarak vkarak merged commit b780dd6 into reframe-hpc:master Mar 8, 2021
@teojgo teojgo deleted the test/required_version_semver branch May 21, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants