Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Mar 10, 2021

Also add an example that shows the RegressionMixin.

Addresses #1691.

Also add an example that shows the `RegressionMixin`.
@vkarak vkarak added this to the ReFrame sprint 21.03.1 milestone Mar 10, 2021
@vkarak vkarak requested review from ekouts and jjotero March 10, 2021 21:35
@vkarak vkarak self-assigned this Mar 10, 2021
@jgphpc
Copy link
Contributor

jgphpc commented Mar 11, 2021

Suggested change: tutorial_basics.rst line 73:

Finally, a test must either define an executable

I would move this part before the part about sanity:

Each regression test must always define

@jgphpc
Copy link
Contributor

jgphpc commented Mar 11, 2021

tutorial_basics.rst, line 131: add

(you can control this through the --keep-stage-files command-line option)

or

(see reframe --help)

?

@jgphpc
Copy link
Contributor

jgphpc commented Mar 11, 2021

typo in line 641 of tutorial_basics.rst

wee convert that to

at the same time (line 757) sent

and the same time being send to Syslog

Copy link
Contributor

@jjotero jjotero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've spotted two other uses of the word parameter which might be misleading, since they do not refer to the parameter built-in. They're both in tutorials_basic:

  • Line 59: Rename parameter to variables. Also, the sentence in this line is now a bit obsolete, since the user can just define the variables directly in the class body.
  • Line 1065: I'd just remove the word parameters.

@jgphpc
Copy link
Contributor

jgphpc commented Mar 11, 2021

tutorial_basics.rst, line 798, typo: in order to access

tutorial_advanced.rst, line 166, typo: coniguration

tutorial_advanced.rst, line 214, typo: proceed

@vkarak
Copy link
Contributor Author

vkarak commented Mar 12, 2021

(see reframe --help)

I don't want to put too many details in the tutorial.

@vkarak vkarak requested review from jgphpc, jjotero and teojgo March 15, 2021 13:14
Copy link
Contributor

@jjotero jjotero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit 31f17f5 into reframe-hpc:master Mar 16, 2021
@vkarak vkarak deleted the docs/use-parameter-in-tutorial branch March 16, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants