-
Notifications
You must be signed in to change notification settings - Fork 117
[doc] Update tutorial examples to use the parameter builtin #1857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Update tutorial examples to use the parameter builtin #1857
Conversation
Also add an example that shows the `RegressionMixin`.
|
Suggested change: tutorial_basics.rst line 73:
I would move this part before the part about sanity:
|
|
tutorial_basics.rst, line 131: add
or
? |
|
typo in line 641 of tutorial_basics.rst
at the same time (line 757) sent
|
jjotero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've spotted two other uses of the word parameter which might be misleading, since they do not refer to the parameter built-in. They're both in tutorials_basic:
- Line 59: Rename parameter to variables. Also, the sentence in this line is now a bit obsolete, since the user can just define the variables directly in the class body.
- Line 1065: I'd just remove the word
parameters.
|
tutorial_basics.rst, line 798, typo: in order to acce tutorial_advanced.rst, line 166, typo: coniguration tutorial_advanced.rst, line 214, typo: |
I don't want to put too many details in the tutorial. |
jjotero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Also add an example that shows the
RegressionMixin.Addresses #1691.