Skip to content

Conversation

@victorusu
Copy link
Contributor

This introduces the Nvidia SMI tests that check whether Accounting, Compute and ECC modes are set to the correct values.

@pep8speaks
Copy link

pep8speaks commented Mar 11, 2021

Hello @victorusu, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2021-03-15 17:45:41 UTC

@vkarak vkarak added this to the ReFrame sprint 21.03.1 milestone Mar 12, 2021
@vkarak
Copy link
Contributor

vkarak commented Mar 12, 2021

I am not sure that the location of the test is correct. Perhaps remove the nvidia/ subfolder.

@vkarak
Copy link
Contributor

vkarak commented Mar 12, 2021

In order to put everything to the class body, you need #1862.

@codecov-io
Copy link

Codecov Report

Merging #1861 (76f3c3c) into master (ed40b22) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1861   +/-   ##
=======================================
  Coverage   87.61%   87.61%           
=======================================
  Files          49       49           
  Lines        8141     8141           
=======================================
  Hits         7133     7133           
  Misses       1008     1008           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed40b22...76f3c3c. Read the comment docs.

@vkarak vkarak requested review from jjotero and removed request for ekouts March 12, 2021 21:41
@vkarak
Copy link
Contributor

vkarak commented Mar 12, 2021

@victorusu I simplified and modernized the test. That's the new way! @jjotero Please confirm :-) We are also almost to the point of getting rid completely of __init__() in all cases. By the way, I don't why you were checking also the Pending ECC Mode. Did you have to? I am not checking it here, because I wanted to keep the test simpler.

Copy link
Contributor

@jjotero jjotero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@teojgo teojgo changed the title [test] Add flexible nvidia-smi check [test] Add nvidia-smi check Mar 16, 2021
@vkarak vkarak merged commit ff10fa4 into reframe-hpc:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants