-
Notifications
You must be signed in to change notification settings - Fork 117
[test] Add nvidia-smi check #1861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @victorusu, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2021-03-15 17:45:41 UTC |
|
I am not sure that the location of the test is correct. Perhaps remove the |
|
In order to put everything to the class body, you need #1862. |
Codecov Report
@@ Coverage Diff @@
## master #1861 +/- ##
=======================================
Coverage 87.61% 87.61%
=======================================
Files 49 49
Lines 8141 8141
=======================================
Hits 7133 7133
Misses 1008 1008 Continue to review full report at Codecov.
|
|
@victorusu I simplified and modernized the test. That's the new way! @jjotero Please confirm :-) We are also almost to the point of getting rid completely of |
jjotero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This introduces the Nvidia SMI tests that check whether Accounting, Compute and ECC modes are set to the correct values.