Skip to content

[bugfix] Do not reset sourcesdir to None if it is set to a URL #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 19, 2021
Merged

[bugfix] Do not reset sourcesdir to None if it is set to a URL #1874

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb86c7a
Fix sourcesdir reset
jjotero Mar 17, 2021
bc62e0f
Make the unit tests happy again
jjotero Mar 17, 2021
94265e9
Fix conflicts
jjotero Mar 17, 2021
ae2566e
Do revert the changes for real now.
jjotero Mar 17, 2021
5b1927f
Merge branch 'master' into bugfix/set-sourcesdir
Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion reframe/core/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,7 +842,8 @@ def _rfm_init(self, name=None, prefix=None):

# Static directories of the regression check
self._prefix = os.path.abspath(prefix)
if not os.path.isdir(os.path.join(self._prefix, self.sourcesdir)):
if (not os.path.isdir(os.path.join(self._prefix, self.sourcesdir)) and
not osext.is_url(self.sourcesdir)):
self.sourcesdir = None

# Runtime information of the test
Expand Down