Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Mar 19, 2021

It is a common mistake to forget to define the sanity_patterns. Now tests not defining them, will be skipped and a warning message will be issued, similarly to valid_systems and valid_prog_environs.

@vkarak vkarak added this to the ReFrame sprint 21.03.1 milestone Mar 19, 2021
@vkarak vkarak requested a review from ekouts March 19, 2021 00:19
@vkarak vkarak self-assigned this Mar 19, 2021
@codecov-io
Copy link

Codecov Report

Merging #1876 (d367f1d) into master (ed40b22) will increase coverage by 0.23%.
The diff coverage is 94.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1876      +/-   ##
==========================================
+ Coverage   87.61%   87.85%   +0.23%     
==========================================
  Files          49       49              
  Lines        8141     8405     +264     
==========================================
+ Hits         7133     7384     +251     
- Misses       1008     1021      +13     
Impacted Files Coverage Δ
reframe/core/variables.py 94.83% <93.93%> (-1.64%) ⬇️
reframe/core/exceptions.py 94.59% <100.00%> (+0.39%) ⬆️
reframe/core/meta.py 100.00% <100.00%> (ø)
reframe/core/namespaces.py 95.00% <100.00%> (+1.89%) ⬆️
reframe/core/parameters.py 98.50% <100.00%> (+0.04%) ⬆️
reframe/core/pipeline.py 91.96% <100.00%> (-0.02%) ⬇️
reframe/frontend/loader.py 92.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c253dcf...d367f1d. Read the comment docs.

@vkarak vkarak merged commit 4d21a13 into reframe-hpc:master Mar 22, 2021
@vkarak vkarak deleted the feat/skip-tests-sanity-patterns-none branch March 22, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants