[test] Add PrgEnv checks for HIP #1880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarak
reviewed
Mar 24, 2021
victorusu
reviewed
Apr 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #1880 +/- ##
=======================================
Coverage 87.91% 87.91%
=======================================
Files 50 50
Lines 8637 8637
=======================================
Hits 7593 7593
Misses 1044 1044 Continue to review full report at Codecov.
|
Contributor
|
It seems that the test now fails on Dom. |
Contributor
Author
|
It seems that the options for some env vars were updated during a minor release ... 😭 |
vkarak
approved these changes
Apr 21, 2021
Contributor
|
@jenkins-cscs retry none |
vkarak
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test that builds the HIP ecosystem around the existing
nvcccompiler, and another hello world test that checks that the build was successful.The second test makes obvious the need for the changes to be introduced with #1868. However, the dependency of the hello world test on the build test would be better explained through fixtures (#1577).