Skip to content

Conversation

@jjotero
Copy link
Contributor

@jjotero jjotero commented Mar 24, 2021

When a test with one or more undefined parameters was decorated, it the decorator would raise an error saying that the test is an abstract test. This error message might not be very clear to the user, so it is now changed to something more intuitive.

The "abstract test" nomenclature has been kept in the unit tests to keep things short, and a definition has also been added there for clarity.

@mabraham
Copy link
Contributor

This would have helped me help myself better in #1887

@vkarak vkarak added this to the ReFrame sprint 21.04.1 milestone Mar 25, 2021
@jjotero jjotero linked an issue Mar 30, 2021 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #1888 (85dca12) into master (7eef1a8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1888   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files          49       49           
  Lines        8451     8451           
=======================================
  Hits         7429     7429           
  Misses       1022     1022           
Impacted Files Coverage Δ
reframe/core/meta.py 100.00% <ø> (ø)
reframe/core/decorators.py 97.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eef1a8...85dca12. Read the comment docs.

@vkarak vkarak changed the title [feat] Improve error message when params are undefined [feat] Improve error message when parameters are undefined Apr 2, 2021
@vkarak vkarak merged commit 8bf4581 into reframe-hpc:master Apr 2, 2021
@jjotero jjotero deleted the feat/improve-error-messages branch April 3, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants