Skip to content

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented Mar 25, 2021

SUMMARY OF FAILURES
------------------------------------------------------------------------------
FAILURE INFO for BZip2Check 
  * Test Description: This demonstrates the EasyBuild build system.
  * System partition: daint:gpu
  * Environment: builtin
  * Stage directory: /users/sarafael/reframe-tmp/reframe/stage/daint/gpu/builtin/BZip2Check
  * Node list: None
  * Job type: batch job (id=None)
  * Dependencies (conceptual): []
  * Dependencies (actual): []
  * Maintainers: []
  * Failing phase: compile_wait
  * Rerun with '-n BZip2Check -p builtin --system daint:gpu -r'
  * Reason: file not found error: [Errno 2] No such file or directory: 'rfm_BZip2Check_build.out'

To reproduce it

import reframe as rfm
import reframe.utility.sanity as sn


class EasybuildMixin(rfm.RegressionTest):
    @rfm.run_before('run')
    def prepare_run(self):
        self.modules = self.build_system.generated_modules


@rfm.simple_test
class BZip2Check(EasybuildMixin):
    def __init__(self):
        self.descr = 'This demonstrates the EasyBuild build system.'
        self.valid_systems = ['dom:gpu', 'daint:gpu']
        self.valid_prog_environs = ['builtin']
        self.modules = ['EasyBuild-custom']
        self.build_system = 'EasyBuild'
        self.build_system.easyconfigs = ['bzip2-1.0.6.eb']
        self.build_system.options = ['-f']
        self.sanity_patterns = sn.assert_found(r'Version 1.0.6', self.stderr)
        self.executable = 'bzip2'
        self.executable_opts = ['--help']

@rsarm rsarm added this to the ReFrame sprint 21.03.2 milestone Mar 25, 2021
@rsarm rsarm requested review from victorusu and vkarak March 25, 2021 08:24
@rsarm rsarm self-assigned this Mar 25, 2021
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be fixed if we simply switched to stagedir when calling post_build?

@rsarm
Copy link
Contributor Author

rsarm commented Apr 2, 2021

@vkarak yes, I think so. Also I think we wouldn't need self._prefix_save.

@codecov-io
Copy link

Codecov Report

Merging #1891 (bfc78b3) into master (0208843) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1891      +/-   ##
==========================================
- Coverage   87.94%   87.90%   -0.04%     
==========================================
  Files          49       49              
  Lines        8453     8451       -2     
==========================================
- Hits         7434     7429       -5     
- Misses       1019     1022       +3     
Impacted Files Coverage Δ
reframe/core/buildsystems.py 96.20% <0.00%> (-0.03%) ⬇️
reframe/core/pipeline.py 92.00% <100.00%> (-0.03%) ⬇️
reframe/utility/typecheck.py 94.54% <0.00%> (-0.91%) ⬇️
reframe/core/schedulers/slurm.py 52.43% <0.00%> (-0.29%) ⬇️
reframe/utility/osext.py 84.71% <0.00%> (ø)
reframe/frontend/loader.py 92.50% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0208843...bfc78b3. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I've also updated the documentation of post_build().

@vkarak vkarak merged commit d0a3c53 into reframe-hpc:master Apr 2, 2021
@rsarm rsarm deleted the bugfix/eb-buildout branch February 3, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants