Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Mar 30, 2021

Fixes #1855

@teojgo teojgo added this to the ReFrame sprint 21.03.2 milestone Mar 30, 2021
@teojgo teojgo requested review from ekouts and vkarak March 30, 2021 07:22
@teojgo teojgo self-assigned this Mar 30, 2021
Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [bugfix] Color 'bootstrap.sh' only if stdout is a terminal [bugfix] Color bootstrap.sh only if stdout is a terminal Mar 31, 2021
@codecov-io
Copy link

Codecov Report

Merging #1898 (eccc068) into master (21abab2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1898   +/-   ##
=======================================
  Coverage   87.92%   87.92%           
=======================================
  Files          49       49           
  Lines        8450     8450           
=======================================
  Hits         7430     7430           
  Misses       1020     1020           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21abab2...eccc068. Read the comment docs.

@vkarak vkarak merged commit 5f3c919 into reframe-hpc:master Mar 31, 2021
@teojgo teojgo deleted the bugfix/bootstrap_nocolor branch May 21, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to disable colours in output of bootstrap.sh

4 participants