[refactor] Consolidate unit test fixtures and other refactoring of unit tests #1923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 8, 2021 23:38
- The `temp_runtime` fixture that was defined in different files is now replaced by the more general `make_exec_ctx` fixture and defined inside `unittests.fixtures`. All unit tests that were making use of the old fixtures are now updated. - The `unittests.fixtures` module now contains only pytest fixtures. The rest utilities are moved to a separate module `unittests.utility`.
vkarak
force-pushed
the
refactor/consolidate-unit-test-fixtures
branch
from
291667e to
2e1bab6
Compare
Contributor
|
You can also take a look at |
vkarak
force-pushed
the
refactor/consolidate-unit-test-fixtures
branch
from
519b307 to
ee4e515
Compare
teojgo
approved these changes
Apr 9, 2021
jjotero
approved these changes
Apr 9, 2021
Contributor
Author
|
@jenkins-cscs retry daint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temp_runtimefixture that was defined in different files is now replaced by the more generalmake_exec_ctxfixture and defined insideunittests.fixtures. All unit tests that were making use of the old fixtures are now updated.unittests.fixturesmodule now contains only pytest fixtures. The rest utilities are moved to a separate moduleunittests.utility.Fixes #1913.
Fixes #1551.