-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Deprecate the use of the @parameterized_test decorator
#1934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Deprecate the use of the @parameterized_test decorator
#1934
Conversation
|
Hello @vkarak, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2021-04-19 13:33:29 UTC |
Codecov Report
@@ Coverage Diff @@
## master #1934 +/- ##
=========================================
Coverage ? 87.88%
=========================================
Files ? 50
Lines ? 8610
Branches ? 0
=========================================
Hits ? 7567
Misses ? 1043
Partials ? 0
Continue to review full report at Codecov.
|
jjotero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also add a few fixmes or perhaps even create an issue to do the cleanup after the deprecation is done.
The main thing that I have in mind is the _register_test function, which can be massively simplified to just forward whichever *args and **kwargs from the decorator to the test constructor.
Also, (this one is for 4.0) I think it would also make sense to change the simple_test decorator to just @test.
Fixes #1849.
Implementation details
Since I had to convert everything to the built-in
parameterin the unit tests, I introduced the notion of force loading the test, in which case the loader first unloads the test module if it has already been loaded and then reloads it. This change is implemented in a larger extent in #1848, but here I am only using it in one unit test.