From 7086c420c302601954e7c4626d5c67afc62e9865 Mon Sep 17 00:00:00 2001 From: Eirini Koutsaniti Date: Mon, 26 Apr 2021 09:30:59 +0200 Subject: [PATCH 1/4] Give a warning when search path files don't exist --- reframe/frontend/cli.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/reframe/frontend/cli.py b/reframe/frontend/cli.py index 21f2f23ae8..e01feda79a 100644 --- a/reframe/frontend/cli.py +++ b/reframe/frontend/cli.py @@ -610,6 +610,12 @@ def main(): printer.debug(format_env(options.env_vars)) + # Check that the check path files exist + if options.checkpath: + for f in options.checkpath: + if not os.path.exists(f): + printer.warning(f"check path {f} doesn't exist") + # Setup the check loader if options.restore_session is not None: # We need to load the failed checks only from a report From 9bdaf153ace1c60e9a680ab4009ea1047b111e53 Mon Sep 17 00:00:00 2001 From: Eirini Koutsaniti Date: Tue, 27 Apr 2021 15:14:28 +0200 Subject: [PATCH 2/4] Give a warning when search path files don't exist v2 --- reframe/frontend/cli.py | 6 ------ reframe/frontend/loader.py | 1 + 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/reframe/frontend/cli.py b/reframe/frontend/cli.py index e01feda79a..21f2f23ae8 100644 --- a/reframe/frontend/cli.py +++ b/reframe/frontend/cli.py @@ -610,12 +610,6 @@ def main(): printer.debug(format_env(options.env_vars)) - # Check that the check path files exist - if options.checkpath: - for f in options.checkpath: - if not os.path.exists(f): - printer.warning(f"check path {f} doesn't exist") - # Setup the check loader if options.restore_session is not None: # We need to load the failed checks only from a report diff --git a/reframe/frontend/loader.py b/reframe/frontend/loader.py index e5dcd74252..21b0ab721b 100644 --- a/reframe/frontend/loader.py +++ b/reframe/frontend/loader.py @@ -203,6 +203,7 @@ def load_all(self, force=False): for d in self._load_path: getlogger().debug(f'Looking for tests in {d!r}') if not os.path.exists(d): + getlogger().warning(f"check path {d} doesn't exist") continue if os.path.isdir(d): From 781360879229591231ae1855590d0d49cbf55a20 Mon Sep 17 00:00:00 2001 From: Eirini Koutsaniti Date: Tue, 27 Apr 2021 15:15:56 +0200 Subject: [PATCH 3/4] Give a warning when search path files don't exist v3 --- reframe/frontend/loader.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reframe/frontend/loader.py b/reframe/frontend/loader.py index 21b0ab721b..15380d96bf 100644 --- a/reframe/frontend/loader.py +++ b/reframe/frontend/loader.py @@ -203,7 +203,7 @@ def load_all(self, force=False): for d in self._load_path: getlogger().debug(f'Looking for tests in {d!r}') if not os.path.exists(d): - getlogger().warning(f"check path {d} doesn't exist") + getlogger().warning(f"check path {d!r} doesn't exist") continue if os.path.isdir(d): From 20367b714126ba7464bd3a6fb7a275cfe66f3862 Mon Sep 17 00:00:00 2001 From: Vasileios Karakasis Date: Tue, 27 Apr 2021 21:00:32 +0200 Subject: [PATCH 4/4] Address PR comments --- reframe/frontend/loader.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reframe/frontend/loader.py b/reframe/frontend/loader.py index 15380d96bf..d3fa9175d9 100644 --- a/reframe/frontend/loader.py +++ b/reframe/frontend/loader.py @@ -203,7 +203,7 @@ def load_all(self, force=False): for d in self._load_path: getlogger().debug(f'Looking for tests in {d!r}') if not os.path.exists(d): - getlogger().warning(f"check path {d!r} doesn't exist") + getlogger().warning(f'check path {d!r} does not exist') continue if os.path.isdir(d):