Skip to content

[bugfix] Fix error checking of module commands in the class Tmod backends #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2021
Merged

[bugfix] Fix error checking of module commands in the class Tmod backends #1971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions reframe/core/modules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,7 +637,7 @@ def modulecmd(self, *args):
def _execute(self, cmd, *args):
modulecmd = self.modulecmd(cmd, *args)
completed = osext.run_command(modulecmd)
if re.search(r'ERROR', completed.stderr) is not None:
if re.search(r'\bERROR\b', completed.stderr) is not None:
raise SpawnedProcessError(modulecmd,
completed.stdout,
completed.stderr,
Expand Down Expand Up @@ -769,7 +769,7 @@ def modulecmd(self, *args):
def _execute(self, cmd, *args):
modulecmd = self.modulecmd(cmd, *args)
completed = osext.run_command(modulecmd)
if re.search(r'ERROR', completed.stderr) is not None:
if re.search(r'\bERROR\b', completed.stderr) is not None:
raise SpawnedProcessError(modulecmd,
completed.stdout,
completed.stderr,
Expand Down
1 change: 1 addition & 0 deletions unittests/modules/testmod_bar
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ conflict testmod_foo
conflict testmod_boo

setenv TESTMOD_BAR "BAR"
setenv TESTMOD_ERROR "BARERROR"