Skip to content

[code quality] Test that stagedir is mounted inside container #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2021
Merged

[code quality] Test that stagedir is mounted inside container #1984

merged 2 commits into from
May 25, 2021

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented May 25, 2021

Fixes #1845

@teojgo teojgo added this to the ReFrame sprint 21.05.1 milestone May 25, 2021
@teojgo teojgo requested review from victorusu and vkarak May 25, 2021 13:11
@teojgo teojgo self-assigned this May 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2021 •
edited
Loading

Codecov Report

Merging #1984 (f8ae925) into master (8bd06ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1984   +/-   ##
=======================================
  Coverage   87.59%   87.59%           
=======================================
  Files          50       50           
  Lines        8770     8770           
=======================================
  Hits         7682     7682           
  Misses       1088     1088

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd06ea...f8ae925. Read the comment docs.

victorusu
victorusu approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

vkarak
vkarak approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit 7c463e6 into reframe-hpc:master May 25, 2021
@teojgo teojgo deleted the code_quality/test_stage_mount_container branch August 13, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@victorusu victorusu victorusu approved these changes

Assignees

@teojgo teojgo

Labels

code quality prio: normal

Projects

None yet

Milestone

ReFrame sprint 21.05.1

Development

Successfully merging this pull request may close these issues.

Create unittest to ensure that stagedir is passed to the container platform

4 participants

@teojgo @codecov-commenter @vkarak @victorusu